paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 13:33:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

stream_settings: Add Not subscribed tab to stream settings.

Browse Source 
This commit adds a new tab to the stream settings overlay called
"Not subscribed" which lists all the streams the user is not
subscribed to. This tab is disabled if the user is a guest.

Introduced a new variable called "show_not_subscribed" to replicate
a similar model to how the subscribed tab is working. Currently,
there are only two tabs: "subscribed" and "all streams" so we can
use an if-else condition.

Refactored the 'update_stream_row_in_settings_tab' function inside
stream_ui_updates.js to include the case of a 'Not-subscribed' tab,
so that the tab is immediately updated in any add/remove subscription
event.

Fixed and added the node tests for these changes.
This commit is contained in:
sujal shah
2024-05-08 21:30:20 +05:30
committed by Tim Abbott
parent d7936fe576
commit 6deb165ef6
6 changed files with 196 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
web/e2e-tests/subscribe_toggle.test.ts
View File

@@ -3,6 +3,9 @@ import type {ElementHandle, Page} from "puppeteer";
import * as common from "./lib/common";
async function test_subscription_button(page: Page): Promise<void> {
const all_stream_selector = "[data-tab-key='all-streams']";
await page.waitForSelector(all_stream_selector, {visible: true});
await page.click(all_stream_selector);
const stream_selector = "[data-stream-name='Venice']";
const button_selector = `${stream_selector} .sub_unsub_button`;
const subscribed_selector = `${button_selector}.checked`;