paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_edit: Avoid confusing notice editing wildcard mention messages.

Browse Source 
It's highly confusing to suggest to a user that we'll send a second
notification to all users when that's not the case.

Fixes #25507.
This commit is contained in:
Tim Abbott
2023-05-09 17:54:57 -07:00
parent 859a96e0d7
commit 6e0ea3d79a
1 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
web/src/message_edit.js
View File

@@ -907,6 +907,8 @@ export function save_message_row_edit($row) {
changed = old_content !== new_content;
}
const already_has_wildcard_mention = message.wildcard_mentioned;
if (!already_has_wildcard_mention) {
const wildcard_mention = util.find_wildcard_mentions(new_content);
const is_stream_message_mentions_valid = compose_validate.validate_stream_message_mentions(
stream_id,
@@ -916,6 +918,7 @@ export function save_message_row_edit($row) {
if (!is_stream_message_mentions_valid) {
return;
}
}
show_message_edit_spinner($row);