diff --git a/static/js/avatar.js b/static/js/avatar.js index 018611393a..4bec7b7974 100644 --- a/static/js/avatar.js +++ b/static/js/avatar.js @@ -105,6 +105,7 @@ export function build_user_avatar_widget(upload_function) { html_body, html_yes_button: $t_html({defaultMessage: "Confirm"}), on_click: delete_user_avatar, + fade: true, }); }); diff --git a/static/js/confirm_dialog.js b/static/js/confirm_dialog.js index 06602d7095..0efee522da 100644 --- a/static/js/confirm_dialog.js +++ b/static/js/confirm_dialog.js @@ -32,7 +32,7 @@ import * as overlays from "./overlays"; */ export function launch(conf) { - const html = render_confirm_dialog(); + const html = render_confirm_dialog({fade: conf.fade}); const confirm_dialog = $(html); const conf_fields = [ @@ -47,7 +47,7 @@ export function launch(conf) { ]; for (const f of conf_fields) { - if (!conf[f]) { + if (conf[f] === undefined) { blueslip.error("programmer omitted " + f); } } diff --git a/static/js/settings_emoji.js b/static/js/settings_emoji.js index 4dba3c96e7..4f06bb7b9a 100644 --- a/static/js/settings_emoji.js +++ b/static/js/settings_emoji.js @@ -251,6 +251,7 @@ export function set_up() { html_body, html_yes_button: $t_html({defaultMessage: "Yes"}), on_click: submit_custom_emoji_request, + fade: true, }); } else { submit_custom_emoji_request(); diff --git a/static/js/settings_invites.js b/static/js/settings_invites.js index 4b8e566c84..ed9cced603 100644 --- a/static/js/settings_invites.js +++ b/static/js/settings_invites.js @@ -208,6 +208,7 @@ export function on_load_success(invites_data, initialize_event_handlers) { html_body, html_yes_button: $t_html({defaultMessage: "Confirm"}), on_click: do_revoke_invite, + fade: true, }); $(".confirm_dialog_yes_button").attr("data-invite-id", meta.invite_id); @@ -233,6 +234,7 @@ export function on_load_success(invites_data, initialize_event_handlers) { html_body, html_yes_button: $t_html({defaultMessage: "Confirm"}), on_click: do_resend_invite, + fade: true, }); $(".confirm_dialog_yes_button").attr("data-invite-id", meta.invite_id); diff --git a/static/js/settings_org.js b/static/js/settings_org.js index 938d6ea704..c3566d79be 100644 --- a/static/js/settings_org.js +++ b/static/js/settings_org.js @@ -1168,6 +1168,7 @@ export function build_page() { html_body, html_yes_button: $t_html({defaultMessage: "Confirm"}), on_click: do_deactivate_realm, + fade: true, }); }); } diff --git a/static/js/settings_user_groups.js b/static/js/settings_user_groups.js index f1a75442f0..adf564668a 100644 --- a/static/js/settings_user_groups.js +++ b/static/js/settings_user_groups.js @@ -368,6 +368,7 @@ export function set_up() { html_body, html_yes_button: $t_html({defaultMessage: "Confirm"}), on_click: delete_user_group, + fade: true, }); }); diff --git a/static/js/settings_users.js b/static/js/settings_users.js index a4809ac726..db1b80f3e6 100644 --- a/static/js/settings_users.js +++ b/static/js/settings_users.js @@ -519,6 +519,7 @@ function confirm_deactivation(row, user_id, status_field) { html_body, html_yes_button: $t_html({defaultMessage: "Confirm"}), on_click: handle_confirm, + fade: true, }); } diff --git a/static/js/stream_edit.js b/static/js/stream_edit.js index f8e4d7855a..9b1e4f3be6 100644 --- a/static/js/stream_edit.js +++ b/static/js/stream_edit.js @@ -872,6 +872,7 @@ export function initialize() { html_body, html_yes_button: $t_html({defaultMessage: "Confirm"}), on_click: remove_user_from_private_stream, + fade: true, }); return; } @@ -940,6 +941,7 @@ export function initialize() { html_body, html_yes_button: $t_html({defaultMessage: "Confirm"}), on_click: do_archive_stream, + fade: true, }); $(".confirm_dialog_yes_button").attr("data-stream-id", stream_id); diff --git a/static/js/subs.js b/static/js/subs.js index 42b82dbe68..a9fc2c1f56 100644 --- a/static/js/subs.js +++ b/static/js/subs.js @@ -971,6 +971,7 @@ export function unsubscribe_from_private_stream(sub, from_stream_popover) { html_body, html_yes_button: $t_html({defaultMessage: "Confirm"}), on_click: unsubscribe_from_stream, + fade: true, }); } diff --git a/static/templates/confirm_dialog.hbs b/static/templates/confirm_dialog.hbs index 063c205d9f..7720a2a24a 100644 --- a/static/templates/confirm_dialog.hbs +++ b/static/templates/confirm_dialog.hbs @@ -1,4 +1,4 @@ -