paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 04:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

puppeteer: Use a better approach to open user popover.

Browse Source 
This commit improves the approach to click on the menu
icon on the right sidebar. It'd first hover on the list
instead of the menu to avoid the occasional "HTML node
not present" error. As menu icon our only visible when
we hover over the item.
This commit is contained in:
Riken Shah
2021-07-28 18:26:34 +00:00
committed by Tim Abbott
parent 2a2654d5f5
commit 6eb88eb3ef
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
frontend_tests/puppeteer_tests/user-status.ts
View File

@@ -3,10 +3,11 @@ import type {Page} from "puppeteer";
import common from "../puppeteer_lib/common";
async function open_set_user_status_modal(page: Page): Promise<void> {
const buddy_list_menu_icon = "#user_presences .user-list-sidebar-menu-icon";
await page.hover(buddy_list_menu_icon);
await page.waitForSelector(buddy_list_menu_icon, {visible: true});
await page.click(buddy_list_menu_icon);
const buddy_list_me_item = "#user_presences .user_sidebar_entry:first-child";
await page.hover(buddy_list_me_item);
const menu_icon_selector = buddy_list_me_item + " .user-list-sidebar-menu-icon";
await page.waitForSelector(menu_icon_selector, {visible: true});
await page.click(menu_icon_selector);
await page.waitForSelector(".user_popover", {visible: true});
// We are using evaluate to click because it is very hard to detect if the user info popover has opened.
await page.evaluate(() =>