paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_list: More descriptive names for {show,hide}_topic_edit.

Browse Source 
Clarify that the functions show and hide the topic edit in the recipient
row, and do not apply to the message edit rows.
This commit is contained in:
Puneeth Chaganti
2020-04-05 23:31:55 +05:30
committed by Tim Abbott
parent cd64d2dd27
commit 6f2d0c0288
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
static/js/click_handlers.js
View File

@@ -309,7 +309,7 @@ exports.initialize = function () {
}); });
$("body").on("click", ".topic_edit_cancel", function (e) { $("body").on("click", ".topic_edit_cancel", function (e) {
const recipient_row = $(this).closest(".recipient_row"); const recipient_row = $(this).closest(".recipient_row");
current_msg_list.hide_edit_topic(recipient_row); current_msg_list.hide_edit_topic_on_recipient_row(recipient_row);
e.stopPropagation(); e.stopPropagation();
popovers.hide_all(); popovers.hide_all();
}); });

4
static/js/message_edit.js
View File

@@ -426,7 +426,7 @@ exports.start = function (row, edit_box_open_callback) {
exports.start_topic_edit = function (recipient_row) { exports.start_topic_edit = function (recipient_row) {
const form = $(render_topic_edit_form()); const form = $(render_topic_edit_form());
current_msg_list.show_edit_topic(recipient_row, form); current_msg_list.show_edit_topic_on_recipient_row(recipient_row, form);
form.keydown(_.partial(handle_edit_keydown, true)); form.keydown(_.partial(handle_edit_keydown, true));
const msg_id = rows.id_for_recipient_row(recipient_row); const msg_id = rows.id_for_recipient_row(recipient_row);
const message = current_msg_list.get(msg_id); const message = current_msg_list.get(msg_id);
@@ -461,7 +461,7 @@ exports.end = function (row) {
current_msg_list.hide_edit_message(row); current_msg_list.hide_edit_message(row);
} }
if (row !== undefined) { if (row !== undefined) {
current_msg_list.hide_edit_topic(row); current_msg_list.hide_edit_topic_on_recipient_row(row);
} }
condense.show_message_expander(row); condense.show_message_expander(row);
row.find(".message_reactions").show(); row.find(".message_reactions").show();

4
static/js/message_list.js
View File

@@ -316,7 +316,7 @@ exports.MessageList.prototype = {
row.trigger("mouseleave"); row.trigger("mouseleave");
}, },
show_edit_topic: function MessageList_show_edit_topic(recipient_row, form) { show_edit_topic_on_recipient_row: function (recipient_row, form) {
recipient_row.find(".topic_edit_form").empty().append(form); recipient_row.find(".topic_edit_form").empty().append(form);
recipient_row.find('.on_hover_topic_edit').hide(); recipient_row.find('.on_hover_topic_edit').hide();
recipient_row.find('.edit_content_button').hide(); recipient_row.find('.edit_content_button').hide();
@@ -324,7 +324,7 @@ exports.MessageList.prototype = {
recipient_row.find(".topic_edit").show(); recipient_row.find(".topic_edit").show();
}, },
hide_edit_topic: function MessageList_hide_edit_topic(recipient_row) { hide_edit_topic_on_recipient_row: function (recipient_row) {
recipient_row.find(".stream_topic").show(); recipient_row.find(".stream_topic").show();
recipient_row.find('.on_hover_topic_edit').show(); recipient_row.find('.on_hover_topic_edit').show();
recipient_row.find('.edit_content_button').show(); recipient_row.find('.edit_content_button').show();