paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 13:33:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

emoji: Refactor get_emoji_details_by_name function.

Browse Source 
This is a prep commit for typescript migration of `emoji.js`. This
commit refactors the code for generating emoji rendering details such
that we avoid writing an ugly code which will involve writing an
incomplete type object when we migrate to TypeScript.
This commit is contained in:
Lalit
2023-04-05 16:21:26 +05:30
committed by Tim Abbott
parent 30204ed694
commit 6f46c4830f
3 changed files with 21 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
web/tests/emoji.test.js
View File

@@ -76,6 +76,7 @@ run_test("get_emoji_details_by_name", () => {
reaction_type: "zulip_extra_emoji",
emoji_code: "zulip",
url: "/static/generated/emoji/images/emoji/unicode/zulip.png",
still_url: null,
});
// Test adding realm emoji.
@@ -97,6 +98,7 @@ run_test("get_emoji_details_by_name", () => {
reaction_type: "realm_emoji",
emoji_code: "102",
url: "/some/path/to/emoji",
still_url: null,
});
// Test sending without emoji name.