paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-16 20:02:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs: Update code-reviewing docs to reflect CI changes.

Browse Source
This commit is contained in:
Vishnu Ks
2018-12-28 11:51:13 +00:00
committed by Tim Abbott
parent cddce5bd34
commit 6f5b1903c4
2 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
docs/contributing/code-reviewing.md
View File

@@ -67,17 +67,19 @@ this?". Good choices include
## Things to look for ## Things to look for
* *The Travis CI build.* The tests need to pass. One can investigate * *The CI build.* The tests need to pass. One can investigate
any failures and figure out what to fix by clicking on a red X next any failures and figure out what to fix by clicking on a red X next
to the commit hash or the Detail links on a pull request. (Example: to the commit hash or the Detail links on a pull request. (Example:
in [#1219](https://github.com/zulip/zulip/pull/1219), click the red in [#10618](https://github.com/zulip/zulip/pull/10618), browse to
X next to `f1f474e` to see the build jobs for that commit, at least bottom and click the red X next to `c6044ee` to see the build jobs
one of which has failed. Click on the link for Travis continuous for that commit. You can see that there are 4 build jobs in total.
integrations details to see [the tests Travis ran on that 3 are by CircleCI and 1 is by Travis CI. You can see what caused
commit](https://travis-ci.org/zulip/zulip/builds/144300899), at the job to fail by clicking on the failed job. This will open
least one of which failed, and go to [one of the failing up a page in the CI that has more details on why the job failed.
tests](https://travis-ci.org/zulip/zulip/jobs/144300901) to see the For example [this](https://circleci.com/gh/zulip/zulip/16617)
error.) is the page of the `bionic-python-3.6` job. See our docs on
[continuous integration](../testing/continuous-integration.html)
to learn more.
* *Technical design.* There are a lot of considerations here: * *Technical design.* There are a lot of considerations here:
security, migration paths/backwards compatibility, cost of new security, migration paths/backwards compatibility, cost of new

1
tools/documentation_crawler/documentation_crawler/spiders/common/spiders.py
View File

@@ -18,6 +18,7 @@ EXCLUDED_URLS = [
'https://www.git-tower.com/blog/command-line-cheat-sheet/', 'https://www.git-tower.com/blog/command-line-cheat-sheet/',
# Requires authentication # Requires authentication
'https://circleci.com/gh/zulip/zulip', 'https://circleci.com/gh/zulip/zulip',
'https://circleci.com/gh/zulip/zulip/16617',
] ]