mirror of
https://github.com/zulip/zulip.git
synced 2025-11-16 20:02:15 +00:00
docs: Update code-reviewing docs to reflect CI changes.
This commit is contained in:
@@ -67,17 +67,19 @@ this?". Good choices include
|
||||
|
||||
## Things to look for
|
||||
|
||||
* *The Travis CI build.* The tests need to pass. One can investigate
|
||||
* *The CI build.* The tests need to pass. One can investigate
|
||||
any failures and figure out what to fix by clicking on a red X next
|
||||
to the commit hash or the Detail links on a pull request. (Example:
|
||||
in [#1219](https://github.com/zulip/zulip/pull/1219), click the red
|
||||
X next to `f1f474e` to see the build jobs for that commit, at least
|
||||
one of which has failed. Click on the link for Travis continuous
|
||||
integrations details to see [the tests Travis ran on that
|
||||
commit](https://travis-ci.org/zulip/zulip/builds/144300899), at
|
||||
least one of which failed, and go to [one of the failing
|
||||
tests](https://travis-ci.org/zulip/zulip/jobs/144300901) to see the
|
||||
error.)
|
||||
in [#10618](https://github.com/zulip/zulip/pull/10618), browse to
|
||||
bottom and click the red X next to `c6044ee` to see the build jobs
|
||||
for that commit. You can see that there are 4 build jobs in total.
|
||||
3 are by CircleCI and 1 is by Travis CI. You can see what caused
|
||||
the job to fail by clicking on the failed job. This will open
|
||||
up a page in the CI that has more details on why the job failed.
|
||||
For example [this](https://circleci.com/gh/zulip/zulip/16617)
|
||||
is the page of the `bionic-python-3.6` job. See our docs on
|
||||
[continuous integration](../testing/continuous-integration.html)
|
||||
to learn more.
|
||||
|
||||
* *Technical design.* There are a lot of considerations here:
|
||||
security, migration paths/backwards compatibility, cost of new
|
||||
|
||||
@@ -18,6 +18,7 @@ EXCLUDED_URLS = [
|
||||
'https://www.git-tower.com/blog/command-line-cheat-sheet/',
|
||||
# Requires authentication
|
||||
'https://circleci.com/gh/zulip/zulip',
|
||||
'https://circleci.com/gh/zulip/zulip/16617',
|
||||
]
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user