From 707af5ab567a506c64e85b05206d138254802cad Mon Sep 17 00:00:00 2001 From: Tim Abbott Date: Fri, 16 Mar 2018 11:32:14 -0700 Subject: [PATCH] cache: Remove a now-unnecessary TODO. We solved the problem the TODO raised by using a different type annotation syntax, and I'm not sure whether that refactor would actually improve the code. --- zerver/lib/cache.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/zerver/lib/cache.py b/zerver/lib/cache.py index 68d856ea84..31ec7c0a43 100644 --- a/zerver/lib/cache.py +++ b/zerver/lib/cache.py @@ -318,9 +318,6 @@ def user_profile_by_id_cache_key(user_profile_id: int) -> Text: def user_profile_by_api_key_cache_key(api_key: Text) -> Text: return "user_profile_by_api_key:%s" % (api_key,) -# TODO: Refactor these cache helpers into another file that can import -# models.py so that python v3 style type annotations can also work. - realm_user_dict_fields = [ 'id', 'full_name', 'short_name', 'email', 'avatar_source', 'avatar_version', 'is_active',