paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-16 11:52:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

test_user_groups: Fix database access outside test function.

Browse Source 
Python evaluates function parameter defaults at definition time, not
call time.  This function wouldn’t work with other realms anyway.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2023-10-16 15:08:06 -07:00
committed by Anders Kaseorg
parent d94bdb3900
commit 70af7d7c58
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
zerver/tests/test_user_groups.py
View File

@@ -52,11 +52,9 @@ class UserGroupTestCase(ZulipTestCase):
subgroup_ids = get_subgroup_ids(user_group, direct_subgroup_only=True) subgroup_ids = get_subgroup_ids(user_group, direct_subgroup_only=True)
self.assertSetEqual(set(subgroup_ids), {member.id for member in members}) self.assertSetEqual(set(subgroup_ids), {member.id for member in members})
def create_user_group_for_test( def create_user_group_for_test(self, group_name: str) -> UserGroup:
self, group_name: str, realm: Realm = get_realm("zulip")
) -> UserGroup:
members = [self.example_user("othello")] members = [self.example_user("othello")]
return check_add_user_group(realm, group_name, members, acting_user=None) return check_add_user_group(get_realm("zulip"), group_name, members, acting_user=None)
def test_user_groups_in_realm_serialized(self) -> None: def test_user_groups_in_realm_serialized(self) -> None:
realm = get_realm("zulip") realm = get_realm("zulip")