paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 06:53:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: Add more tests around exception handling.

Browse Source 
This verifies that we actually do enqueue a record when there is an
error on non-staging.  With the previous commit, it verifies that that
data serializes correctly.
This commit is contained in:
Alex Vandiver
2020-08-14 01:04:10 -07:00
committed by Tim Abbott
parent 69a7944c48
commit 70e8cc5783
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
zerver/tests/test_logging_handlers.py
View File

@@ -157,6 +157,9 @@ class AdminNotifyHandlerTest(ZulipTestCase):
self.assertIn("message", report) self.assertIn("message", report)
self.assertIn("stack_trace", report) self.assertIn("stack_trace", report)
# Put it back so we continue to test the non-anonymous case
record.request.user = self.example_user('hamlet')
# Now simulate a DisallowedHost exception # Now simulate a DisallowedHost exception
def get_host_error() -> None: def get_host_error() -> None:
raise Exception("Get Host Failure!") raise Exception("Get Host Failure!")
@@ -190,8 +193,17 @@ class AdminNotifyHandlerTest(ZulipTestCase):
self.handler.emit(record) self.handler.emit(record)
with self.settings(STAGING_ERROR_NOTIFICATIONS=False): with self.settings(STAGING_ERROR_NOTIFICATIONS=False):
with mock_queue_publish('zerver.logging_handlers.queue_json_publish', with mock_queue_publish('zerver.logging_handlers.queue_json_publish',
side_effect=Exception("queue error")): side_effect=Exception("queue error")) as m:
with patch('logging.warning') as log_mock:
self.handler.emit(record) self.handler.emit(record)
m.assert_called_once()
log_mock.assert_called_once_with('Reporting an exception triggered an exception!',
exc_info=True)
with mock_queue_publish('zerver.logging_handlers.queue_json_publish') as m:
with patch('logging.warning') as log_mock:
self.handler.emit(record)
m.assert_called_once()
log_mock.assert_not_called()
# Test no exc_info # Test no exc_info
record.exc_info = None record.exc_info = None