paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-01 12:33:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

message: Do not allow guest to mention inaccessible users.

Browse Source
This commit is contained in:
Sahil Batra
2023-12-02 13:24:36 +05:30
committed by Tim Abbott
parent ac441b77fa
commit 72aa4b256d
8 changed files with 82 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
zerver/tests/test_notification_data.py
View File

@@ -384,7 +384,7 @@ class TestNotificationData(ZulipTestCase):
result = get_user_group_mentions_data(
mentioned_user_ids=set(),
mentioned_user_group_ids=[],
mention_data=MentionData(mention_backend, "no group mentioned"),
mention_data=MentionData(mention_backend, "no group mentioned", message_sender=None),
)
self.assertDictEqual(result, {})
@@ -392,7 +392,9 @@ class TestNotificationData(ZulipTestCase):
result = get_user_group_mentions_data(
mentioned_user_ids=set(),
mentioned_user_group_ids=[hamlet_and_cordelia.id],
mention_data=MentionData(mention_backend, "hey @*hamlet_and_cordelia*!"),
mention_data=MentionData(
mention_backend, "hey @*hamlet_and_cordelia*!", message_sender=None
),
)
self.assertDictEqual(
result,
@@ -408,7 +410,9 @@ class TestNotificationData(ZulipTestCase):
mentioned_user_ids=set(),
mentioned_user_group_ids=[hamlet_and_cordelia.id, hamlet_only.id],
mention_data=MentionData(
mention_backend, "hey @*hamlet_and_cordelia* and @*hamlet_only*"
mention_backend,
"hey @*hamlet_and_cordelia* and @*hamlet_only*",
message_sender=None,
),
)
self.assertDictEqual(
@@ -425,7 +429,9 @@ class TestNotificationData(ZulipTestCase):
mentioned_user_ids=set(),
mentioned_user_group_ids=[hamlet_only.id, hamlet_and_cordelia.id],
mention_data=MentionData(
mention_backend, "hey @*hamlet_only* and @*hamlet_and_cordelia*"
mention_backend,
"hey @*hamlet_only* and @*hamlet_and_cordelia*",
message_sender=None,
),
)
self.assertDictEqual(
@@ -441,7 +447,9 @@ class TestNotificationData(ZulipTestCase):
result = get_user_group_mentions_data(
mentioned_user_ids={hamlet.id},
mentioned_user_group_ids=[hamlet_and_cordelia.id],
mention_data=MentionData(mention_backend, "hey @*hamlet_and_cordelia*!"),
mention_data=MentionData(
mention_backend, "hey @*hamlet_and_cordelia*!", message_sender=None
),
)
self.assertDictEqual(
result,