paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 14:35:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_list: Extract clear_date_divider_html.

Browse Source 
This also fixes the fact that the logic had swapped which object
should be undefined and which should be false.
This commit is contained in:
Tim Abbott
2019-02-08 11:07:25 -08:00
parent fe28d0731e
commit 72bb3fb6c2
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
static/js/message_list_view.js
View File

@@ -93,6 +93,11 @@ function update_group_time_display(group, message_container, prev) {
} }
} }
function clear_group_date_divider(group) {
group.show_date_separator = false;
group.show_date = undefined;
}
function update_timestr(message_container) { function update_timestr(message_container) {
if (message_container.timestr === undefined) { if (message_container.timestr === undefined) {
var time = new XDate(message_container.msg.timestamp * 1000); var time = new XDate(message_container.msg.timestamp * 1000);
@@ -407,9 +412,7 @@ MessageListView.prototype = {
new_message_groups = _.rest(new_message_groups); new_message_groups = _.rest(new_message_groups);
} else if (first_group !== undefined && second_group !== undefined) { } else if (first_group !== undefined && second_group !== undefined) {
if (same_day(prev_msg_container, curr_msg_container)) { if (same_day(prev_msg_container, curr_msg_container)) {
// Clear the date if it is the same as the last group clear_group_date_divider(second_group);
second_group.show_date = false;
second_group.show_date_separator = undefined;
} else { } else {
// If we just sent the first message on a new day // If we just sent the first message on a new day
// in a narrow, make sure we render a date separator. // in a narrow, make sure we render a date separator.