paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 05:23:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

stream_topic_history: Track the most recent message in streams.

Browse Source 
This adds a way to keep track of max_message_id of a
stream and fetch it using the method get_max_message_id().

This will be useful for sorting streams by most recent
activity which will be implemented in the upcoming commit.

Essentially rewritten by tabbott to have a coherent tracking system,
and provide documentation.

Part of #10794.
This commit is contained in:
Hashir Sarwar
2020-04-30 15:11:18 +05:00
committed by Tim Abbott
parent 5598f8f6b0
commit 735785f985
2 changed files with 55 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
frontend_tests/node_tests/stream_topic_history.js
View File

@@ -16,7 +16,9 @@ run_test('basics', () => {
});
let history = stream_topic_history.get_recent_topic_names(stream_id);
let max_message_id = stream_topic_history.get_max_message_id(stream_id);
assert.deepEqual(history, ['toPic1']);
assert.deepEqual(max_message_id, 101);
stream_topic_history.add_message({
stream_id: stream_id,
@@ -24,7 +26,9 @@ run_test('basics', () => {
topic_name: 'Topic1',
});
history = stream_topic_history.get_recent_topic_names(stream_id);
max_message_id = stream_topic_history.get_max_message_id(stream_id);
assert.deepEqual(history, ['Topic1']);
assert.deepEqual(max_message_id, 102);
stream_topic_history.add_message({
stream_id: stream_id,
@@ -32,7 +36,9 @@ run_test('basics', () => {
topic_name: 'topic2',
});
history = stream_topic_history.get_recent_topic_names(stream_id);
max_message_id = stream_topic_history.get_max_message_id(stream_id);
assert.deepEqual(history, ['topic2', 'Topic1']);
assert.deepEqual(max_message_id, 103);
// Removing first topic1 message has no effect.
stream_topic_history.remove_message({
@@ -41,6 +47,9 @@ run_test('basics', () => {
});
history = stream_topic_history.get_recent_topic_names(stream_id);
assert.deepEqual(history, ['topic2', 'Topic1']);
// Removing a topic message shouldn't effect the max_message_id.
max_message_id = stream_topic_history.get_max_message_id(stream_id);
assert.deepEqual(max_message_id, 103);
// Removing second topic1 message removes the topic.
stream_topic_history.remove_message({