paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-21 23:19:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

bootstrap_typeahead: Remove create and lookup API.

Browse Source 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2024-05-06 13:31:24 -07:00
committed by Tim Abbott
parent acf93eac4b
commit 7360fd2a67
9 changed files with 32 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
web/tests/composebox_typeahead.test.js
View File

@@ -799,7 +799,7 @@ test("initialize", ({override, override_rewire, mock_template}) => {
let topic_typeahead_called = false;
let pm_recipient_typeahead_called = false;
let compose_textarea_typeahead_called = false;
override(bootstrap_typeahead, "create", (input_element, options) => {
override(bootstrap_typeahead, "Typeahead", (input_element, options) => {
switch (input_element.$element) {
case $("input#stream_message_recipient_topic"): {
override_rewire(stream_topic_history, "get_recent_topic_names", (stream_id) => {

2
web/tests/pill_typeahead.test.js
View File

@@ -159,7 +159,7 @@ run_test("set_up", ({mock_template, override, override_rewire}) => {
}
let opts = {};
override(bootstrap_typeahead, "create", (input_element, config) => {
override(bootstrap_typeahead, "Typeahead", (input_element, config) => {
assert.equal(input_element.$element, $fake_input);
assert.equal(config.items, 5);
assert.ok(config.fixed);

16
web/tests/search.test.js
View File

@@ -18,6 +18,8 @@ mock_esm("../src/filter", {
const search = zrequire("search");
let typeahead_forced_open = false;
run_test("initialize", ({override, override_rewire, mock_template}) => {
const $search_query_box = $("#search_query");
const $searchbox_form = $("#searchbox_form");
@@ -36,7 +38,7 @@ run_test("initialize", ({override, override_rewire, mock_template}) => {
search_suggestion.max_num_of_search_results = 999;
let terms;
override(bootstrap_typeahead, "create", (input_element, opts) => {
override(bootstrap_typeahead, "Typeahead", (input_element, opts) => {
assert.equal(input_element.$element, $search_query_box);
assert.equal(opts.items, 999);
assert.equal(opts.naturalSearch, true);
@@ -207,7 +209,11 @@ run_test("initialize", ({override, override_rewire, mock_template}) => {
$search_query_box.off("blur");
}
return {};
return {
lookup() {
typeahead_forced_open = true;
},
};
});
search.initialize({
@@ -306,17 +312,13 @@ run_test("initialize", ({override, override_rewire, mock_template}) => {
assert.ok(is_blurred);
});
run_test("initiate_search", ({override}) => {
run_test("initiate_search", () => {
// open typeahead and select text when navbar is open
// this implicitly expects the code to used the chained
// function calls, which is something to keep in mind if
// this test ever fails unexpectedly.
narrow_state.filter = () => ({is_keyword_search: () => false});
let typeahead_forced_open = false;
let is_searchbox_text_selected = false;
override(bootstrap_typeahead, "lookup", () => {
typeahead_forced_open = true;
});
$("#search_query").on("select", () => {
is_searchbox_text_selected = true;
});