paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

casper: Add a few more explicit waits to message editing tests.

Browse Source 
This is a second attempt at fixing a casper test flake we've been
having recently.
This commit is contained in:
Tim Abbott
2017-11-20 16:18:02 -08:00
parent c7f47f5477
commit 73e4d647c7
1 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
frontend_tests/casper_tests/12-toggle-message-editing.js
View File

@@ -166,13 +166,21 @@ casper.then(function () {
casper.then(function () { casper.then(function () {
casper.waitUntilVisible('input[type="checkbox"][id="id_realm_allow_message_editing"] + span', function () { casper.waitUntilVisible('input[type="checkbox"][id="id_realm_allow_message_editing"] + span', function () {
casper.click('input[type="checkbox"][id="id_realm_allow_message_editing"] + span'); casper.click('input[type="checkbox"][id="id_realm_allow_message_editing"] + span');
});
});
casper.then(function () {
casper.waitUntilVisible('input:checked[type="checkbox"][id="id_realm_allow_message_editing"] + span', function () {
casper.click('form.org-settings-form button.button'); casper.click('form.org-settings-form button.button');
casper.waitUntilVisible('#admin-realm-message-editing-status', function () { });
casper.test.assertSelectorHasText('#admin-realm-message-editing-status', 'Users can now edit topics for all their messages, and the content of messages which are less than 10 minutes old.'); });
casper.test.assertEval(function () {
return document.querySelector('input[type="checkbox"][id="id_realm_allow_message_editing"]').checked; casper.then(function () {
}, 'Allow message editing Setting re-activated'); casper.waitUntilVisible('#admin-realm-message-editing-status', function () {
}); casper.test.assertSelectorHasText('#admin-realm-message-editing-status', 'Users can now edit topics for all their messages, and the content of messages which are less than 10 minutes old.');
casper.test.assertEval(function () {
return document.querySelector('input[type="checkbox"][id="id_realm_allow_message_editing"]').checked;
}, 'Allow message editing Setting re-activated');
}); });
}); });