From 74148f2e0bad61b28889071b9ca1d390c546ed2e Mon Sep 17 00:00:00 2001 From: Maneesh Shukla <143504391+shuklamaneesh23@users.noreply.github.com> Date: Mon, 4 Aug 2025 22:32:07 +0530 Subject: [PATCH] desktop-notification-banner: Remove the banner form the org settings. The `update_desktop_notification_banner` line removed had been added in #34865, to handle the case of opening the default user settings panel after previously opening the personal; notifications settings panel, and is no longer required. --- web/src/settings_notifications.ts | 2 -- web/templates/settings/notification_settings.hbs | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/web/src/settings_notifications.ts b/web/src/settings_notifications.ts index 06ac5896e2..a1619d30be 100644 --- a/web/src/settings_notifications.ts +++ b/web/src/settings_notifications.ts @@ -388,8 +388,6 @@ export function set_up(settings_panel: SettingsPanel): void { settings_object.automatically_unmute_topics_in_muted_streams_policy, ); - update_desktop_notification_banner(); - $container.on("click", ".desktop-notifications-request", (e) => { e.preventDefault(); // This is only accessed via the notifications banner, so we diff --git a/web/templates/settings/notification_settings.hbs b/web/templates/settings/notification_settings.hbs index 8016f33ae7..bc28ac9c26 100644 --- a/web/templates/settings/notification_settings.hbs +++ b/web/templates/settings/notification_settings.hbs @@ -131,7 +131,9 @@ {{> settings_save_discard_widget section_name="desktop-message-settings" show_only_indicator=(not for_realm_settings) }} + {{#if (eq prefix "user_")}}
+ {{/if}} {{#unless for_realm_settings}} {{> ../components/action_button