paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 15:03:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

copy-paste: Fix edge cases on message selection for copying.

Browse Source 
When we detect that multiple messages are selected, copying will copy the
entirety of each message that is selected. [more conversation on that
here](https://chat.zulip.org/#narrow/stream/6-frontend/topic/triple.20click.20.2B.20copy.20paste.20bug/near/1398292).

This commit fixes a bug where we would select the entirety of a message
following a selection even when none of that last message's text was
selected (only some HTML element in the messages's container).

Fixes #18706.
This commit is contained in:
evykassirer
2022-04-04 15:15:34 -07:00
committed by Tim Abbott
parent 96b2e18b0d
commit 747ea8e84d
1 changed files with 23 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
static/js/copy_and_paste.js
View File

@@ -268,6 +268,29 @@ function get_end_tr_from_endc($endc) {
return $(".message_row").last(); return $(".message_row").last();
} }
// Sometimes (especially when three click selecting in Chrome) the selection
// can end in a hidden element in e.g. the next message, a date divider.
// We can tell this is the case because the selection isn't inside a
// `messagebox-content` div, which is where the message text itself is.
// TODO: Ideally make it so that the selection cannot end there.
// For now, we find find the message row directly above wherever the
// selection ended.
if ($endc.closest(".messagebox-content").length === 0) {
// If the selection ends within the message following the selected
// messages, go back to use the actual last message.
if ($endc.parents(".message_row").length > 0) {
const $parent_msg = $($endc.parents(".message_row")[0]);
return $parent_msg.prev(".message_row");
}
// If it's not in a .message_row, it's probably in a .message_header and
// we can use the last message from the previous recipient_row.
if ($endc.parents(".message_header").length > 0) {
const $overflow_recipient_row = $($endc.parents(".recipient_row")[0]);
return $overflow_recipient_row.prev(".recipient_row").last(".message_row");
}
// If somehow we get here, do the default return.
}
return $($endc.parents(".selectable_row")[0]); return $($endc.parents(".selectable_row")[0]);
} }