paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 04:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

node_tests: Use const for constants.

Browse Source
This commit is contained in:
Priyank
2018-04-12 21:40:03 +00:00
committed by showell
parent 4fbdfef63b
commit 7490932e1b
1 changed files with 56 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

120
frontend_tests/node_tests/activity.js
View File

@@ -65,45 +65,45 @@ set_global('resize', {
});
set_global('window', 'window-stub');
var me = {
const me = {
email: 'me@zulip.com',
user_id: 999,
full_name: 'Me Myself',
};
var alice = {
const alice = {
email: 'alice@zulip.com',
user_id: 1,
full_name: 'Alice Smith',
};
var fred = {
const fred = {
email: 'fred@zulip.com',
user_id: 2,
full_name: "Fred Flintstone",
};
var jill = {
const jill = {
email: 'jill@zulip.com',
user_id: 3,
full_name: 'Jill Hill',
};
var mark = {
const mark = {
email: 'mark@zulip.com',
user_id: 4,
full_name: 'Marky Mark',
};
var norbert = {
const norbert = {
email: 'norbert@zulip.com',
user_id: 5,
full_name: 'Norbert Oswald',
};
var zoe = {
const zoe = {
email: 'zoe@example.com',
user_id: 6,
full_name: 'Zoe Yang',
};
var people = global.people;
const people = global.people;
people.add_in_realm(alice);
people.add_in_realm(fred);
@@ -116,14 +116,14 @@ people.initialize_current_user(me.user_id);
compose_fade.update_faded_users = function () {};
var real_update_huddles = activity.update_huddles;
const real_update_huddles = activity.update_huddles;
activity.update_huddles = function () {};
global.compile_template('user_presence_row');
global.compile_template('user_presence_rows');
global.compile_template('group_pms');
var presence_info = {};
const presence_info = {};
presence_info[alice.user_id] = { status: 'inactive' };
presence_info[fred.user_id] = { status: 'active' };
presence_info[jill.user_id] = { status: 'active' };
@@ -149,7 +149,7 @@ presence.presence_info = presence_info;
}());
(function test_sort_users() {
var user_ids = [alice.user_id, fred.user_id, jill.user_id];
const user_ids = [alice.user_id, fred.user_id, jill.user_id];
activity._sort_users(user_ids);
@@ -162,15 +162,15 @@ presence.presence_info = presence_info;
(function test_process_loaded_messages() {
var huddle1 = 'jill@zulip.com,norbert@zulip.com';
var timestamp1 = 1382479029; // older
const huddle1 = 'jill@zulip.com,norbert@zulip.com';
const timestamp1 = 1382479029; // older
var huddle2 = 'alice@zulip.com,fred@zulip.com';
var timestamp2 = 1382479033; // newer
const huddle2 = 'alice@zulip.com,fred@zulip.com';
const timestamp2 = 1382479033; // newer
var old_timestamp = 1382479000;
const old_timestamp = 1382479000;
var messages = [
const messages = [
{
type: 'private',
display_recipient: [{id: jill.user_id}, {id: norbert.user_id}],
@@ -197,8 +197,8 @@ presence.presence_info = presence_info;
activity.process_loaded_messages(messages);
var user_ids_string1 = people.emails_strings_to_user_ids_string(huddle1);
var user_ids_string2 = people.emails_strings_to_user_ids_string(huddle2);
const user_ids_string1 = people.emails_strings_to_user_ids_string(huddle1);
const user_ids_string2 = people.emails_strings_to_user_ids_string(huddle2);
assert.deepEqual(activity.get_huddles(), [user_ids_string2, user_ids_string1]);
}());
@@ -249,7 +249,7 @@ presence.presence_info = presence_info;
var huddle = 'alice@zulip.com,fred@zulip.com,jill@zulip.com,mark@zulip.com';
huddle = people.emails_strings_to_user_ids_string(huddle);
var presence_info = {};
const presence_info = {};
presence_info[alice.user_id] = { status: 'active' };
presence_info[fred.user_id] = { status: 'idle' }; // counts as present
// jill not in list
@@ -272,9 +272,9 @@ presence.presence_info[me.user_id] = { status: activity.ACTIVE };
activity.set_user_list_filter();
var user_order = [fred.user_id, jill.user_id, norbert.user_id,
const user_order = [fred.user_id, jill.user_id, norbert.user_id,
zoe.user_id, alice.user_id, mark.user_id];
var user_count = 6;
const user_count = 6;
// Mock the jquery is func
$('.user-list-filter').is = function (sel) {
@@ -297,7 +297,7 @@ $('#user_presences li.user_sidebar_entry.narrow-filter').last = function () {
$('.user-list-filter').focus();
$('#user_presences li.user_sidebar_entry.narrow-filter');
var users = activity.build_user_sidebar();
const users = activity.build_user_sidebar();
assert.deepEqual(users, [{
name: 'Fred Flintstone',
href: '#narrow/pm-with/2-fred',
@@ -350,15 +350,15 @@ $('#user_presences li.user_sidebar_entry.narrow-filter').last = function () {
}());
(function test_PM_update_dom_counts() {
var value = $.create('alice-value');
var count = $.create('alice-count');
var pm_key = alice.user_id.toString();
var li = $("li.user_sidebar_entry[data-user-id='" + pm_key + "']");
const value = $.create('alice-value');
const count = $.create('alice-count');
const pm_key = alice.user_id.toString();
const li = $("li.user_sidebar_entry[data-user-id='" + pm_key + "']");
count.set_find_results('.value', value);
li.set_find_results('.count', count);
count.set_parent(li);
var counts = new Dict();
const counts = new Dict();
counts.set(pm_key, 5);
li.addClass('user_sidebar_entry');
@@ -374,16 +374,16 @@ $('#user_presences li.user_sidebar_entry.narrow-filter').last = function () {
}());
(function test_group_update_dom_counts() {
var value = $.create('alice-fred-value');
var count = $.create('alice-fred-count');
var pm_key = alice.user_id.toString() + "," + fred.user_id.toString();
var li_selector = "li.group-pms-sidebar-entry[data-user-ids='" + pm_key + "']";
var li = $(li_selector);
const value = $.create('alice-fred-value');
const count = $.create('alice-fred-count');
const pm_key = alice.user_id.toString() + "," + fred.user_id.toString();
const li_selector = "li.group-pms-sidebar-entry[data-user-ids='" + pm_key + "']";
const li = $(li_selector);
count.set_find_results('.value', value);
li.set_find_results('.count', count);
count.set_parent(li);
var counts = new Dict();
const counts = new Dict();
counts.set(pm_key, 5);
li.addClass('group-pms-sidebar-entry');
@@ -446,12 +446,12 @@ $('#user_presences li.user_sidebar_entry.narrow-filter').last = function () {
// Disable scrolling into place
stream_list.scroll_element_into_container = function () {};
// up
var e = {
const e = {
keyCode: 38,
stopPropagation: function () {},
preventDefault: function () {},
};
var keydown_handler = $('.user-list-filter').get_on_handler('keydown');
const keydown_handler = $('.user-list-filter').get_on_handler('keydown');
keydown_handler(e);
// Now the last element is selected
sel_index = user_count - 1;
@@ -459,20 +459,12 @@ $('#user_presences li.user_sidebar_entry.narrow-filter').last = function () {
sel_index = sel_index - 1;
// down
e = {
keyCode: 40,
stopPropagation: function () {},
preventDefault: function () {},
};
e.keyCode = 40;
keydown_handler(e);
sel_index = sel_index + 1;
keydown_handler(e);
e = {
keyCode: 13,
stopPropagation: function () {},
preventDefault: function () {},
};
e.keyCode = 13;
// Enter text and narrow users
$(".user-list-filter").expectOne().val('ali');
@@ -486,7 +478,7 @@ $('#user_presences li.user_sidebar_entry.narrow-filter').last = function () {
}());
(function test_focus_user_filter() {
var e = {
const e = {
stopPropagation: function () {},
};
var click_handler = $('.user-list-filter').get_on_handler('click');
@@ -494,8 +486,8 @@ $('#user_presences li.user_sidebar_entry.narrow-filter').last = function () {
}());
(function test_focusout_user_filter() {
var e = { };
var click_handler = $('.user-list-filter').get_on_handler('blur');
const e = { };
const click_handler = $('.user-list-filter').get_on_handler('blur');
click_handler(e);
}());
@@ -508,7 +500,7 @@ presence.presence_info[norbert.user_id] = { status: activity.ACTIVE };
presence.presence_info[zoe.user_id] = { status: activity.ACTIVE };
(function test_filter_user_ids() {
var user_filter = $('.user-list-filter');
const user_filter = $('.user-list-filter');
user_filter.val(''); // no search filter
activity.set_user_list_filter();
@@ -551,7 +543,7 @@ presence.presence_info[zoe.user_id] = { status: activity.ACTIVE };
}());
(function test_insert_one_user_into_empty_list() {
var alice_li = $.create('alice list item');
const alice_li = $.create('alice list item');
// These selectors are here to avoid some short-circuit logic.
$('#user_presences').set_find_results('[data-user-id="1"]', alice_li);
@@ -572,7 +564,7 @@ presence.presence_info[zoe.user_id] = { status: activity.ACTIVE };
}());
(function test_insert_fred_after_alice() {
var fred_li = $.create('fred list item');
const fred_li = $.create('fred list item');
// These selectors are here to avoid some short-circuit logic.
$('#user_presences').set_find_results('[data-user-id="2"]', fred_li);
@@ -601,7 +593,7 @@ presence.presence_info[zoe.user_id] = { status: activity.ACTIVE };
}());
(function test_insert_fred_before_jill() {
var fred_li = $.create('fred-li');
const fred_li = $.create('fred-li');
// These selectors are here to avoid some short-circuit logic.
$('#user_presences').set_find_results('[data-user-id="2"]', fred_li);
@@ -637,7 +629,7 @@ activity.set_user_list_filter();
// This test only tests that we do not explode when
// try to insert Fred into a list where he does not
// match the search filter.
var user_filter = $('.user-list-filter');
const user_filter = $('.user-list-filter');
user_filter.val('do-not-match-filter');
activity.insert_user_into_list(fred.user_id);
}());
@@ -716,16 +708,16 @@ $('.user-list-filter').parent = function () {
}());
(function test_update_huddles_and_redraw() {
var value = $.create('alice-fred-value');
var count = $.create('alice-fred-count');
var pm_key = alice.user_id.toString() + "," + fred.user_id.toString();
var li_selector = "li.group-pms-sidebar-entry[data-user-ids='" + pm_key + "']";
var li = $(li_selector);
const value = $.create('alice-fred-value');
const count = $.create('alice-fred-count');
const pm_key = alice.user_id.toString() + "," + fred.user_id.toString();
const li_selector = "li.group-pms-sidebar-entry[data-user-ids='" + pm_key + "']";
const li = $(li_selector);
count.set_find_results('.value', value);
li.set_find_results('.count', count);
count.set_parent(li);
var real_get_huddles = activity.get_huddles;
const real_get_huddles = activity.get_huddles;
activity.get_huddles = function () {
return ['1,2'];
};
@@ -745,14 +737,14 @@ $('.user-list-filter').parent = function () {
}());
(function test_set_user_status() {
var server_time = 500;
var info = {
const server_time = 500;
const info = {
website: {
status: "active",
timestamp: server_time,
},
};
var alice_li = $.create('alice-li');
const alice_li = $.create('alice-li');
$('#user_presences').set_find_results('[data-user-id="1"]', alice_li);
@@ -767,7 +759,7 @@ $('.user-list-filter').parent = function () {
activity.set_user_status(me.email, info, server_time);
assert.equal(presence.presence_info[alice.user_id], undefined);
activity.set_user_status(alice.email, info, server_time);
var expected = { status: 'active', mobile: false, last_active: 500 };
const expected = { status: 'active', mobile: false, last_active: 500 };
assert.deepEqual(presence.presence_info[alice.user_id], expected);
activity.set_user_status(alice.email, info, server_time);
blueslip.warn = function (msg) {