paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-22 07:21:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings: Do not store pill widgets for new groups in map.

Browse Source 
Instead of storing setting pill widgets for new groups
in group_setting_widget_map, we just use variable in the
user_group_create file to store the widget.

This helps in accessing the widget with the key having
"new_group_" as prefix which we want to avoid as a pattern.

Note that the classes and IDs in templates still use
"new_group_" prefix.
This commit is contained in:
Sahil Batra
2024-10-03 08:44:52 +05:30
committed by Tim Abbott
parent 698f3cf41b
commit 74fb851958
2 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
web/src/settings_components.ts
View File

@@ -1404,7 +1404,6 @@ export function initialize_disable_btn_hint_popover(
const group_setting_widget_map = new Map<string, GroupSettingPillContainer | null>([
["can_manage_group", null],
["new_group_can_manage_group", null],
]);
export function get_group_setting_widget(setting_name: string): GroupSettingPillContainer | null {
@@ -1459,7 +1458,7 @@ export function create_group_setting_widget({
setting_name: group_setting_name;
setting_type: "realm" | "stream" | "group";
group?: UserGroup;
}): void {
}): GroupSettingPillContainer {
const pill_widget = group_setting_pill.create_pills(
$pill_container,
setting_name,
@@ -1472,9 +1471,7 @@ export function create_group_setting_widget({
};
group_setting_pill.set_up_pill_typeahead({pill_widget, $pill_container, opts});
if (group === undefined) {
group_setting_widget_map.set("new_group_" + setting_name, pill_widget);
} else {
if (group !== undefined) {
group_setting_widget_map.set(setting_name, pill_widget);
}
@@ -1502,4 +1499,6 @@ export function create_group_setting_widget({
set_group_setting_widget_value(pill_widget, default_group_id);
}
}
return pill_widget;
}