font-awesome: Drop support for legacy font awesome icons.

We drop support for usage of `icon-vector` as base class when
including icons from font awesome icons package.
Now on, only icons as specified in font awesome v4.7.0 can be used
in the code base.

docs/subsystems/user-docs.md

@@ -115,11 +115,11 @@ to be formatted correctly.
 ### Icons
 
 You can refer to features in the Zulip UI by referencing their names
-and their [FontAwesome](http://fontawesome.io) (version 4.7.0) text
-icons within parentheses. **Note:** We are migrating to the modern
-font awesome base class `fa` instead of the older base class
-`icon-vector` when specifying icons. In future we will be removing
-support for the icons with base class `icon-vector`.
+and their [FontAwesome](https://fontawesome.com/v4.7.0/) (version 4.7.0) text
+icons within parentheses. **Note:** We have completed migrating away from older
+base class `icon-vector` and have dropped support for it. We now only support
+icons from [FontAwesome](https://fontawesome.com/v4.7.0/) (version 4.7.0) which
+make use of `fa` as a base class.
 
 * cog (<i class="fa fa-cog"></i>) icon — `cog (<i
 class="fa fa-cog"></i>) icon`

static/js/bundles/commons.js

@@ -14,7 +14,6 @@ import "third/bootstrap/css/bootstrap-btn.css";
 import "third/bootstrap/css/bootstrap-responsive.css";
 import "node_modules/perfect-scrollbar/css/perfect-scrollbar.css";
 import "node_modules/font-awesome/css/font-awesome.css";
-import "third/fontawesome-legacy.css";
 import "generated/icons/style.css";
 import "node_modules/source-sans-pro/source-sans-pro.css";
 import "styles/pygments.scss";

tools/linter_lib/custom_check.py

@@ -570,7 +570,6 @@ def build_custom_checkers(by_lang):
          'bad_lines': ['background: url(https://example.com/image.png);']},
         {'pattern': '^[ ][ ][a-zA-Z0-9]',
          'description': "Incorrect 2-space indentation in CSS",
-         'exclude': set(['static/third/fontawesome-legacy.css']),
          'strip': '\n',
          'good_lines': ["    color: white;", "color: white;"],
          'bad_lines': ["  color: white;"]},

tools/webpack.assets.json

@@ -48,7 +48,6 @@
         "./static/third/bootstrap/css/bootstrap-responsive.css",
         "./node_modules/perfect-scrollbar/css/perfect-scrollbar.css",
         "./node_modules/font-awesome/css/font-awesome.css",
-        "./static/third/fontawesome-legacy.css",
         "./static/generated/icons/style.css",
         "./node_modules/source-sans-pro/source-sans-pro.css",
         "./static/styles/pygments.scss"