From 75ed3f92e210f4fbea50771479c71a9fa9905f14 Mon Sep 17 00:00:00 2001 From: Vishnu Ks Date: Tue, 10 Jul 2018 09:48:54 +0530 Subject: [PATCH] models: Add USER_FULL_NAME_CHANGED event type constant to RealmAuditLog. --- zerver/lib/actions.py | 2 +- zerver/models.py | 1 + zerver/tests/test_audit_log.py | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/zerver/lib/actions.py b/zerver/lib/actions.py index 03a59aa9c4..f3161a094f 100644 --- a/zerver/lib/actions.py +++ b/zerver/lib/actions.py @@ -2804,7 +2804,7 @@ def do_change_full_name(user_profile: UserProfile, full_name: str, user_profile.save(update_fields=["full_name"]) event_time = timezone_now() RealmAuditLog.objects.create(realm=user_profile.realm, acting_user=acting_user, - modified_user=user_profile, event_type='user_full_name_changed', + modified_user=user_profile, event_type=RealmAuditLog.USER_FULL_NAME_CHANGED, event_time=event_time, extra_data=old_name) payload = dict(email=user_profile.email, user_id=user_profile.id, diff --git a/zerver/models.py b/zerver/models.py index b43aa1c830..c9a52b148d 100644 --- a/zerver/models.py +++ b/zerver/models.py @@ -1968,6 +1968,7 @@ class RealmAuditLog(models.Model): USER_REACTIVATED = 'user_reactivated' USER_CHANGE_PASSWORD = 'user_change_password' USER_CHANGE_AVATAR_SOURCE = 'user_change_avatar_source' + USER_FULL_NAME_CHANGED = 'user_full_name_changed' event_type = models.CharField(max_length=40) # type: str diff --git a/zerver/tests/test_audit_log.py b/zerver/tests/test_audit_log.py index 526d28348d..6e0954976f 100644 --- a/zerver/tests/test_audit_log.py +++ b/zerver/tests/test_audit_log.py @@ -69,7 +69,7 @@ class TestRealmAuditLog(ZulipTestCase): req = dict(full_name=ujson.dumps(new_name)) result = self.client_patch('/json/users/{}'.format(self.example_user("hamlet").id), req) self.assertTrue(result.status_code == 200) - query = RealmAuditLog.objects.filter(event_type='user_full_name_changed', + query = RealmAuditLog.objects.filter(event_type=RealmAuditLog.USER_FULL_NAME_CHANGED, event_time__gte=start) self.assertEqual(query.count(), 1)