paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

sidebar_ui: Remove collapsed rows from keyboard navigation.

Browse Source
This commit is contained in:
Aman Agrawal
2025-08-12 20:36:39 +05:30
committed by Tim Abbott
parent 6febd1977a
commit 7731eacac2
1 changed files with 19 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
web/src/sidebar_ui.ts
View File

@@ -466,16 +466,32 @@ export function initialize_right_sidebar(): void {
} }
function all_rows(): JQuery { function all_rows(): JQuery {
// NOTE: This function is designed to be used for keyboard navigation purposes.
// This function returns all the rows in the left sidebar. // This function returns all the rows in the left sidebar.
// It is used to find the first key for the ListCursor. // It is used to find the first key for the ListCursor.
let $all_rows = $(".top_left_row, .bottom_left_row").not(".hidden-by-filters"); const $all_rows = $(".top_left_row, .bottom_left_row").not(".hidden-by-filters");
// Remove rows hidden due to being inactive or muted. // Remove rows hidden due to being inactive or muted.
const $inactive_or_muted_rows = $( const $inactive_or_muted_rows = $(
"#streams_list .stream-list-section-container:not(.showing-inactive-or-muted)" + "#streams_list .stream-list-section-container:not(.showing-inactive-or-muted)" +
" .inactive-or-muted-in-channel-folder .bottom_left_row:not(.hidden-by-filters)", " .inactive-or-muted-in-channel-folder .bottom_left_row:not(.hidden-by-filters)",
); );
$all_rows = $all_rows.not($inactive_or_muted_rows); // Remove rows in collapsed sections / folders.
return $all_rows; const $collapsed_views = $(
"#views-label-container.showing-condensed-navigation +" +
" #left-sidebar-navigation-list .top_left_row",
).not(".top-left-active-filter");
const $collapsed_channels = $(
".stream-list-section-container.collapsed .narrow-filter:not(.stream-expanded) .bottom_left_row",
);
const $hidden_topic_rows = $(
".stream-list-section-container.collapsed .topic-list-item:not(.active-sub-filter).bottom_left_row",
);
return $all_rows
.not($inactive_or_muted_rows)
.not($collapsed_views)
.not($collapsed_channels)
.not($hidden_topic_rows);
} }
class LeftSidebarListCursor extends ListCursor<JQuery> { class LeftSidebarListCursor extends ListCursor<JQuery> {