paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-12 18:06:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

popovers: Extract user_group_popover into separate module.

Browse Source 
This is a preparatory commit before we migrate `user_group_popover`
from Bootstrap to Tippy library.

The previous implementation was weirdly sharing the logic around
`current_message_info_popover_elem` with the user info popovers based
on a message; very likely an unfortunate latent bug caused by
copy/paste.

To address that, we need to add dedicated functions like
get_user_group_popover_items to avoid breaking keyboard navigation
with this extraction.
This commit is contained in:
Daniil Fadeev
2023-09-08 18:44:48 +04:00
committed by Tim Abbott
parent 1765ce23b0
commit 7777c55b22
5 changed files with 151 additions and 91 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
web/src/ui_init.js
View File

@@ -117,6 +117,7 @@ import * as unread_ui from "./unread_ui";
import * as upload from "./upload";
import * as user_group_edit from "./user_group_edit";
import * as user_group_edit_members from "./user_group_edit_members";
import * as user_group_popover from "./user_group_popover";
import * as user_groups from "./user_groups";
import * as user_group_settings_ui from "./user_groups_settings_ui";
import {initialize_user_settings, user_settings} from "./user_settings";
@@ -761,6 +762,7 @@ export function initialize_everything() {
initialize_unread_ui();
activity.initialize();
emoji_picker.initialize();
user_group_popover.initialize();
pm_list.initialize();
topic_list.initialize({
on_topic_click(stream_id, topic) {