paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-11 17:36:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

ruff: Fix C414 Unnecessary list call within sorted().

Browse Source 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2022-10-29 18:35:32 -04:00
committed by Tim Abbott
parent 69e94b5991
commit 77c15547e6
6 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
zerver/actions/message_edit.py
View File

@@ -721,7 +721,7 @@ def do_update_message(
) )
subscriber_ids = set(subscriptions.values_list("user_profile_id", flat=True)) subscriber_ids = set(subscriptions.values_list("user_profile_id", flat=True))
users_to_be_notified += list(map(subscriber_info, sorted(list(subscriber_ids)))) users_to_be_notified += list(map(subscriber_info, sorted(subscriber_ids)))
# UserTopic updates and the content of notifications depend on # UserTopic updates and the content of notifications depend on
# whether we've moved the entire topic, or just part of it. We # whether we've moved the entire topic, or just part of it. We

6
zerver/actions/streams.py
View File

@@ -397,7 +397,7 @@ def send_peer_subscriber_events(
type="subscription", type="subscription",
op=op, op=op,
stream_ids=[stream_id], stream_ids=[stream_id],
user_ids=sorted(list(altered_user_ids)), user_ids=sorted(altered_user_ids),
) )
send_event(realm, event, peer_user_ids) send_event(realm, event, peer_user_ids)
@@ -435,7 +435,7 @@ def send_peer_subscriber_events(
type="subscription", type="subscription",
op=op, op=op,
stream_ids=[stream_id], stream_ids=[stream_id],
user_ids=sorted(list(altered_user_ids)), user_ids=sorted(altered_user_ids),
) )
send_event(realm, event, peer_user_ids) send_event(realm, event, peer_user_ids)
@@ -444,7 +444,7 @@ def send_peer_subscriber_events(
event = dict( event = dict(
type="subscription", type="subscription",
op=op, op=op,
stream_ids=sorted(list(stream_ids)), stream_ids=sorted(stream_ids),
user_ids=[user_id], user_ids=[user_id],
) )
send_event(realm, event, peer_user_ids) send_event(realm, event, peer_user_ids)

2
zerver/lib/digest.py
View File

@@ -306,7 +306,7 @@ def bulk_get_digest_context(
# Get all the recent topics for all the users. This does the heavy # Get all the recent topics for all the users. This does the heavy
# lifting of making an expensive query to the Message table. Then # lifting of making an expensive query to the Message table. Then
# for each user, we filter to just the streams they care about. # for each user, we filter to just the streams they care about.
recent_topics = get_recent_topics(sorted(list(all_stream_ids)), cutoff_date) recent_topics = get_recent_topics(sorted(all_stream_ids), cutoff_date)
stream_map = get_slim_stream_map(all_stream_ids) stream_map = get_slim_stream_map(all_stream_ids)

4
zerver/lib/events.py
View File

@@ -1095,7 +1095,7 @@ def apply_event(
for sub in sub_dict: for sub in sub_dict:
if sub["stream_id"] in stream_ids: if sub["stream_id"] in stream_ids:
subscribers = set(sub["subscribers"]) | user_ids subscribers = set(sub["subscribers"]) | user_ids
sub["subscribers"] = sorted(list(subscribers)) sub["subscribers"] = sorted(subscribers)
elif event["op"] == "peer_remove": elif event["op"] == "peer_remove":
if include_subscribers: if include_subscribers:
stream_ids = set(event["stream_ids"]) stream_ids = set(event["stream_ids"])
@@ -1109,7 +1109,7 @@ def apply_event(
for sub in sub_dict: for sub in sub_dict:
if sub["stream_id"] in stream_ids: if sub["stream_id"] in stream_ids:
subscribers = set(sub["subscribers"]) - user_ids subscribers = set(sub["subscribers"]) - user_ids
sub["subscribers"] = sorted(list(subscribers)) sub["subscribers"] = sorted(subscribers)
else: else:
raise AssertionError("Unexpected event type {type}/{op}".format(**event)) raise AssertionError("Unexpected event type {type}/{op}".format(**event))
elif event["type"] == "presence": elif event["type"] == "presence":

4
zerver/lib/export.py
View File

@@ -1330,7 +1330,7 @@ def export_partial_message_files(
all_message_ids |= message_ids all_message_ids |= message_ids
message_id_chunks = chunkify(sorted(list(all_message_ids)), chunk_size=MESSAGE_BATCH_CHUNK_SIZE) message_id_chunks = chunkify(sorted(all_message_ids), chunk_size=MESSAGE_BATCH_CHUNK_SIZE)
write_message_partials( write_message_partials(
realm=realm, realm=realm,
@@ -2177,7 +2177,7 @@ def export_messages_single_user(
all_message_ids |= reaction_message_ids all_message_ids |= reaction_message_ids
dump_file_id = 1 dump_file_id = 1
for message_id_chunk in chunkify(sorted(list(all_message_ids)), MESSAGE_BATCH_CHUNK_SIZE): for message_id_chunk in chunkify(sorted(all_message_ids), MESSAGE_BATCH_CHUNK_SIZE):
fat_query = ( fat_query = (
UserMessage.objects.select_related("message", "message__sending_client") UserMessage.objects.select_related("message", "message__sending_client")
.filter(user_profile=user_profile, message_id__in=message_id_chunk) .filter(user_profile=user_profile, message_id__in=message_id_chunk)

2
zerver/webhooks/github/view.py
View File

@@ -358,7 +358,7 @@ def get_team_body(helper: Helper) -> str:
new_visibility = payload["team"]["privacy"].tame(check_string) new_visibility = payload["team"]["privacy"].tame(check_string)
return f"Team visibility changed to `{new_visibility}`" return f"Team visibility changed to `{new_visibility}`"
missing_keys = "/".join(sorted(list(changes.keys()))) missing_keys = "/".join(sorted(changes.keys()))
helper.log_unsupported(f"team/edited (changes: {missing_keys})") helper.log_unsupported(f"team/edited (changes: {missing_keys})")
# Do our best to give useful info to the customer--at least # Do our best to give useful info to the customer--at least