paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 13:33:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

test_event_queue: Add missing "super call" in 'MissedMessageHookTest'.

Browse Source 
Earlier, 'MissedMessageHookTest' didn't have 'super().setUp()'
and 'super().tearDown()' in the overrided methods 'setUp' and
'tearDown', respectively, that resulted in cached objects being
used between tests and hence flaky test failures.

This commit adds 'super().setUp()' and 'super().tearDown()'.
This commit is contained in:
Prakhar Pratyush
2023-10-12 21:09:45 +05:30
committed by Tim Abbott
parent 92a9f0a679
commit 78683c1b9c
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
zerver/tests/test_event_queue.py
View File

@@ -183,6 +183,7 @@ class MissedMessageHookTest(ZulipTestCase):
)
def setUp(self) -> None:
super().setUp()
self.user_profile = self.example_user("hamlet")
self.cordelia = self.example_user("cordelia")
do_change_user_setting(
@@ -196,6 +197,7 @@ class MissedMessageHookTest(ZulipTestCase):
def tearDown(self) -> None:
self.destroy_event_queue(self.user_profile, self.client_descriptor.event_queue.id)
super().tearDown()
def test_basic(self) -> None:
with mock.patch("zerver.tornado.event_queue.maybe_enqueue_notifications") as mock_enqueue: