paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 05:23:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

compose: Use file_input class for file input element.

Browse Source 
In both compose and `message_edit_form` we use `file_input`
class to identify the file `input` element. This will help
to more easily share common elements between compose and message_edit.
This commit is contained in:
Aman Agrawal
2021-04-20 14:14:55 +00:00
committed by Tim Abbott
parent eae1829ead
commit 7ae04a6ba8
7 changed files with 14 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
frontend_tests/node_tests/compose.js
View File

@@ -1510,11 +1510,11 @@ test_ui("on_events", (override) => {
(function test_attach_files_compose_clicked() {
const handler = $("#compose").get_on_handler("click", "#attach_files");
$("#file_input").clone = (param) => {
$("#compose .file_input").clone = (param) => {
assert(param);
};
let compose_file_input_clicked = false;
$("#compose #file_input").on("click", () => {
$("#compose .file_input").on("click", () => {
compose_file_input_clicked = true;
});

9
frontend_tests/node_tests/upload.js
View File

@@ -71,7 +71,10 @@ test("get_item", () => {
upload.get_item("send_status_message", {mode: "compose"}),
$("#compose-error-msg"),
);
assert.equal(upload.get_item("file_input_identifier", {mode: "compose"}), "#file_input");
assert.equal(
upload.get_item("file_input_identifier", {mode: "compose"}),
"#compose .file_input",
);
assert.equal(upload.get_item("source", {mode: "compose"}), "compose-file-input");
assert.equal(upload.get_item("drag_drop_container", {mode: "compose"}), $("#compose"));
assert.equal(
@@ -116,7 +119,7 @@ test("get_item", () => {
assert.equal(
upload.get_item("file_input_identifier", {mode: "edit", row: 123}),
`#message_edit_file_input_${CSS.escape(123)}`,
`#edit_form_${CSS.escape(123)} .file_input`,
);
assert.equal(upload.get_item("source", {mode: "edit", row: 123}), "message-edit-file-input");
assert.equal(
@@ -385,7 +388,7 @@ test("uppy_config", () => {
test("file_input", (override) => {
upload.setup_upload({mode: "compose"});
const change_handler = $("body").get_on_handler("change", "#file_input");
const change_handler = $("body").get_on_handler("change", "#compose .file_input");
const files = ["file1", "file2"];
const event = {
target: {