diff --git a/tools/linter_lib/custom_check.py b/tools/linter_lib/custom_check.py index 27b8df059f..4e4d0ac242 100644 --- a/tools/linter_lib/custom_check.py +++ b/tools/linter_lib/custom_check.py @@ -697,6 +697,27 @@ help_markdown_rules = RuleList( length_exclude=markdown_docs_length_exclude, ) +puppet_rules = RuleList( + langs=['pp'], + rules=[ + {'pattern': r'(include\s+|\$)zulip::(profile|base)\b', + 'exclude': { + 'puppet/zulip/manifests/profile/', + 'puppet/zulip_ops/manifests/', + 'puppet/zulip/manifests/dockervoyager.pp', + }, + 'description': 'Abstraction layering violation; only profiles should reference profiles or zulip::base', + }, + {'pattern': r'(include\s+|\$)zulip_ops::(profile|base)\b', + 'exclude': { + 'puppet/zulip/manifests/', + 'puppet/zulip_ops/manifests/profile/', + }, + 'description': 'Abstraction layering violation; only profiles should reference profiles or zulip_ops::base', + }, + ], +) + txt_rules = RuleList( langs=['txt', 'text', 'yaml', 'rst', 'yml'], rules=whitespace_rules, @@ -711,4 +732,5 @@ non_py_rules = [ help_markdown_rules, bash_rules, txt_rules, + puppet_rules, ]