diff --git a/frontend_tests/node_tests/upload.js b/frontend_tests/node_tests/upload.js index 24ed47d5a7..a578a7e955 100644 --- a/frontend_tests/node_tests/upload.js +++ b/frontend_tests/node_tests/upload.js @@ -93,12 +93,16 @@ var upload_opts = upload.options({ mode: "compose" }); function test(i, response, textbox_val) { var compose_ui_autosize_textarea_checked = false; var compose_actions_start_checked = false; + var syntax_to_insert; function setup() { $("#compose-textarea").val(''); compose_ui.autosize_textarea = function () { compose_ui_autosize_textarea_checked = true; }; + compose_ui.insert_syntax_and_focus = function (syntax) { + syntax_to_insert = syntax; + }; compose_state.set_message_type(); global.compose_actions = { start: function (msg_type) { @@ -116,8 +120,8 @@ var upload_opts = upload.options({ mode: "compose" }); } function assert_side_effects() { - assert.equal($("#compose-textarea").val(), textbox_val); if (response.uri) { + assert.equal(syntax_to_insert, textbox_val); assert(compose_actions_start_checked); assert(compose_ui_autosize_textarea_checked); assert.equal($("#compose-send-button").prop('disabled'), false); @@ -131,8 +135,8 @@ var upload_opts = upload.options({ mode: "compose" }); assert_side_effects(); } - var msg_1 = '[pasted image](https://foo.com/uploads/122456) '; - var msg_2 = '[foobar.jpeg](https://foo.com/user_uploads/foobar.jpeg) '; + var msg_1 = '[pasted image](https://foo.com/uploads/122456)'; + var msg_2 = '[foobar.jpeg](https://foo.com/user_uploads/foobar.jpeg)'; test(-1, {}, ''); test(-1, {uri: 'https://foo.com/uploads/122456'}, msg_1); diff --git a/static/js/upload.js b/static/js/upload.js index 03f9cd9803..2fa713485f 100644 --- a/static/js/upload.js +++ b/static/js/upload.js @@ -114,10 +114,12 @@ exports.options = function (config) { if (i === -1) { // This is a paste, so there's no filename. Show the image directly - textarea.val(textarea.val() + "[pasted image](" + uri + ") "); + var pasted_image_uri = "[pasted image](" + uri + ")"; + compose_ui.insert_syntax_and_focus(pasted_image_uri); } else { // This is a dropped file, so make the filename a link to the image - textarea.val(textarea.val() + "[" + filename + "](" + uri + ")" + " "); + var filename_uri = "[" + filename + "](" + uri + ")"; + compose_ui.insert_syntax_and_focus(filename_uri); } compose_ui.autosize_textarea(); send_button.prop("disabled", false);