paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings: Fix incorrect elements used for emojiset loading spinner.

Browse Source 
We were using emojiset_spinner element in destroy_indicator, but
there is no such element and emoji-settings-status element is used
in make_indicator, so destroy_indicator should also use the same
element.

This was added originally in 6cb03ea78e (though in a different
file) and was removed for sometime and then readded in e7311cdf5d.
But between these two commits, the setting was changed to be a
radio element and thus the spinner elements were also changed.
This commit is contained in:
Sahil Batra
2021-08-09 23:23:23 +05:30
committed by Tim Abbott
parent 4b83003b3e
commit 7b74bd1428
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
static/js/settings_display.js
View File

@@ -177,7 +177,7 @@ export async function report_emojiset_change() {
await emojisets.select(user_settings.emojiset); await emojisets.select(user_settings.emojiset);
if ($("#emoji-settings-status").length) { if ($("#emoji-settings-status").length) {
loading.destroy_indicator($("#emojiset_spinner")); loading.destroy_indicator($("#emoji-settings-status"));
$("#emojiset_select").val(user_settings.emojiset); $("#emojiset_select").val(user_settings.emojiset);
ui_report.success( ui_report.success(
$t_html({defaultMessage: "Emojiset changed successfully!"}), $t_html({defaultMessage: "Emojiset changed successfully!"}),