From 7cbf031f185623193a84524dab74caf6889adf41 Mon Sep 17 00:00:00 2001 From: Steve Howell Date: Thu, 6 Dec 2018 21:59:05 +0000 Subject: [PATCH] hashchange: Add warning if pushState is not available. --- frontend_tests/node_tests/hashchange.js | 3 +++ static/js/hashchange.js | 1 + 2 files changed, 4 insertions(+) diff --git a/frontend_tests/node_tests/hashchange.js b/frontend_tests/node_tests/hashchange.js index f961a1c6ab..d267c56b28 100644 --- a/frontend_tests/node_tests/hashchange.js +++ b/frontend_tests/node_tests/hashchange.js @@ -303,7 +303,10 @@ run_test('save_narrow', () => { {operator: 'is', operand: 'private'}, ]; + blueslip.set_test_data('warn', 'browser does not support pushState'); hashchange.save_narrow(operators); + blueslip.clear_test_data(); + helper.assert_events([ 'message_viewport.stop_auto_scrolling', 'favicon.reset', diff --git a/static/js/hashchange.js b/static/js/hashchange.js index 21a813de86..2388148c0d 100644 --- a/static/js/hashchange.js +++ b/static/js/hashchange.js @@ -31,6 +31,7 @@ function set_hash(hash) { var url = get_full_url(hash); history.pushState(null, null, url); } else { + blueslip.warn('browser does not support pushState'); window.location.hash = hash; } }