mirror of
https://github.com/zulip/zulip.git
synced 2025-11-05 22:43:42 +00:00
Add test coverage for parsers in tools/lib.
Now, `tools/test-all` calls a new program called `tools/tests-tools` that runs unit tests in `test_css_parser.py` and 'test_template_parser.py`. This puts 100% line coverage on tools/lib/css_parser.py. This puts about 50% line coverage on tools/lib/template_parser.py.
This commit is contained in:
169
tools/tests/test_css_parser.py
Normal file
169
tools/tests/test_css_parser.py
Normal file
@@ -0,0 +1,169 @@
|
||||
from __future__ import absolute_import
|
||||
from __future__ import print_function
|
||||
|
||||
from typing import cast
|
||||
|
||||
import sys
|
||||
import unittest
|
||||
|
||||
try:
|
||||
from tools.lib.css_parser import (
|
||||
CssParserException,
|
||||
CssSection,
|
||||
parse,
|
||||
)
|
||||
except ImportError:
|
||||
print('ERROR!!! You need to run this via tools/test-tools.')
|
||||
sys.exit(1)
|
||||
|
||||
class ParserTestHappyPath(unittest.TestCase):
|
||||
def test_basic_parse(self):
|
||||
# type: () -> None
|
||||
my_selector = 'li.foo'
|
||||
my_block = '''{
|
||||
color: red;
|
||||
}'''
|
||||
my_css = my_selector + ' ' + my_block
|
||||
res = parse(my_css)
|
||||
self.assertEqual(res.text(), my_css)
|
||||
section = cast(CssSection, res.sections[0])
|
||||
block = section.declaration_block
|
||||
self.assertEqual(block.text().strip(), my_block)
|
||||
declaration = block.declarations[0]
|
||||
self.assertEqual(declaration.css_property, 'color')
|
||||
self.assertEqual(declaration.css_value.text().strip(), 'red')
|
||||
|
||||
def test_same_line_comment(self):
|
||||
# type: () -> None
|
||||
my_css = '''
|
||||
li.hide {
|
||||
display: none; /* comment here */
|
||||
/* Not to be confused
|
||||
with this comment */
|
||||
color: green;
|
||||
}'''
|
||||
res = parse(my_css)
|
||||
section = cast(CssSection, res.sections[0])
|
||||
block = section.declaration_block
|
||||
declaration = block.declarations[0]
|
||||
self.assertIn('/* comment here */', declaration.text())
|
||||
|
||||
def test_multi_line_selector(self):
|
||||
# type: () -> None
|
||||
my_css = '''
|
||||
h1,
|
||||
h2,
|
||||
h3 {
|
||||
top: 0
|
||||
}'''
|
||||
res = parse(my_css)
|
||||
section = res.sections[0]
|
||||
selectors = section.selector_list.selectors
|
||||
self.assertEqual(len(selectors), 3)
|
||||
|
||||
def test_comment_at_end(self):
|
||||
# type: () -> None
|
||||
'''
|
||||
This test verifies the current behavior, which is to
|
||||
attach comments to the preceding rule, but we should
|
||||
probably change it so the comments gets attached to
|
||||
the next block, if possible.
|
||||
'''
|
||||
my_css = '''
|
||||
p {
|
||||
color: black;
|
||||
}
|
||||
|
||||
/* comment at the end of the text */
|
||||
'''
|
||||
res = parse(my_css)
|
||||
self.assertEqual(len(res.sections), 1)
|
||||
section = res.sections[0]
|
||||
self.assertIn('comment at the end', section.post_fluff)
|
||||
|
||||
def test_media_block(self):
|
||||
# type: () -> None
|
||||
my_css = '''
|
||||
@media (max-width: 300px) {
|
||||
h5 {
|
||||
margin: 0;
|
||||
}
|
||||
}'''
|
||||
res = parse(my_css)
|
||||
self.assertEqual(len(res.sections), 1)
|
||||
self.assertEqual(res.text(), my_css)
|
||||
|
||||
class ParserTestSadPath(unittest.TestCase):
|
||||
'''
|
||||
Use this class for tests that verify the parser will
|
||||
appropriately choke on malformed CSS.
|
||||
|
||||
We prevent some things that are technically legal
|
||||
in CSS, like having comments in the middle of list
|
||||
of selectors. Some of this is just for expediency;
|
||||
some of this is to enforce consistent formatting.
|
||||
'''
|
||||
|
||||
def _assert_error(self, my_css, error):
|
||||
# See https://github.com/python/typeshed/issues/372
|
||||
# for why we have to ingore types here.
|
||||
with self.assertRaisesRegexp(CssParserException, error): # type: ignore
|
||||
parse(my_css)
|
||||
|
||||
def test_unexpected_end_brace(self):
|
||||
# type: () -> None
|
||||
my_css = '''
|
||||
@media (max-width: 975px) {
|
||||
body {
|
||||
color: red;
|
||||
}
|
||||
}} /* whoops */'''
|
||||
error = 'unexpected }'
|
||||
self._assert_error(my_css, error)
|
||||
|
||||
def test_empty_section(self):
|
||||
# type: () -> None
|
||||
my_css = '''
|
||||
|
||||
/* nothing to see here, move along */
|
||||
'''
|
||||
error = 'unexpected empty section'
|
||||
self._assert_error(my_css, error)
|
||||
|
||||
def test_missing_colon(self):
|
||||
# type: () -> None
|
||||
my_css = '''
|
||||
.hide
|
||||
{
|
||||
display none /* no colon here */
|
||||
}'''
|
||||
error = 'We expect a colon here'
|
||||
self._assert_error(my_css, error)
|
||||
|
||||
def test_unclosed_comment(self):
|
||||
# type: () -> None
|
||||
my_css = ''' /* comment with no end'''
|
||||
error = 'unclosed comment'
|
||||
self._assert_error(my_css, error)
|
||||
|
||||
def test_missing_selectors(self):
|
||||
# type: () -> None
|
||||
my_css = '''
|
||||
/* no selectors here */
|
||||
{
|
||||
bottom: 0
|
||||
}'''
|
||||
error = 'Missing selector'
|
||||
self._assert_error(my_css, error)
|
||||
|
||||
def test_disallow_comments_in_selectors(self):
|
||||
# type: () -> None
|
||||
my_css = '''
|
||||
h1,
|
||||
h2, /* comment here not allowed by Zulip */
|
||||
h3 {
|
||||
top: 0
|
||||
}'''
|
||||
error = 'Comments in selector section are not allowed'
|
||||
self._assert_error(my_css, error)
|
||||
|
||||
Reference in New Issue
Block a user