paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-11 17:36:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

mypy: Use Dict instead of Mapping in queues.

Browse Source
This commit is contained in:
Umair Khan
2017-09-21 14:11:50 +05:00
committed by Tim Abbott
parent 5eddedd9f6
commit 7d6ddaad26
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
zerver/lib/queue.py
View File

@@ -135,7 +135,7 @@ class SimpleQueueClient(object):
consumer_tag=self._generate_ctag(queue_name))) consumer_tag=self._generate_ctag(queue_name)))
def register_json_consumer(self, queue_name, callback): def register_json_consumer(self, queue_name, callback):
# type: (str, Callable[[Mapping[str, Any]], None]) -> None # type: (str, Callable[[Dict[str, Any]], None]) -> None
def wrapped_callback(ch, method, properties, body): def wrapped_callback(ch, method, properties, body):
# type: (BlockingChannel, Basic.Deliver, pika.BasicProperties, str) -> None # type: (BlockingChannel, Basic.Deliver, pika.BasicProperties, str) -> None
callback(ujson.loads(body)) callback(ujson.loads(body))

6
zerver/worker/queue_processors.py
View File

@@ -108,11 +108,11 @@ class QueueProcessingWorker(object):
raise WorkerDeclarationException("Queue worker declared without queue_name") raise WorkerDeclarationException("Queue worker declared without queue_name")
def consume(self, data): def consume(self, data):
# type: (Mapping[str, Any]) -> None # type: (Dict[str, Any]) -> None
raise WorkerDeclarationException("No consumer defined!") raise WorkerDeclarationException("No consumer defined!")
def consume_wrapper(self, data): def consume_wrapper(self, data):
# type: (Mapping[str, Any]) -> None # type: (Dict[str, Any]) -> None
try: try:
self.consume(data) self.consume(data)
except Exception: except Exception:
@@ -246,7 +246,7 @@ class MissedMessageWorker(QueueProcessingWorker):
@assign_queue('missedmessage_email_senders') @assign_queue('missedmessage_email_senders')
class MissedMessageSendingWorker(QueueProcessingWorker): class MissedMessageSendingWorker(QueueProcessingWorker):
def consume(self, data): def consume(self, data):
# type: (Mapping[str, Any]) -> None # type: (Dict[str, Any]) -> None
try: try:
send_email_from_dict(data) send_email_from_dict(data)
except EmailNotDeliveredException: except EmailNotDeliveredException: