paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-19 14:08:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unescaped use of stream name in subscriptions page.

Browse Source 
This was causing issues with our ability to unsubscribe from
streams with " in their names.

The solution here is a bit hacky, since it depends on the JavaScript
being fairly aware of the layout of the DOM, which is not great.
But it works.

This fixes Trac #328.

(imported from commit a1b6c8e1f3a9daacdc48920a195717aa89b3a9a9)
This commit is contained in:
Waseem Daher
2012-12-12 14:04:08 -05:00
parent 858d638960
commit 7de057dcb0
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
zephyr/jstemplates/subscription.html
View File

@@ -8,8 +8,7 @@
</td> </td>
<td class="span2"> <td class="span2">
<button class="btn btn-block" type="button" name="subscription" <button class="btn btn-block" type="button" name="subscription"
onclick="subs.unsubscribe('{{subscription}}');" onclick="subs.unsubscribe_button_click(event);">Unsubscribe</button>
value="{{subscription}}">Unsubscribe</button>
</td> </td>
</tr> </tr>
{{/with}} {{/with}}

3
zephyr/static/js/subs.js
View File

@@ -229,7 +229,8 @@ function ajaxSubscribe(stream) {
}); });
} }
exports.unsubscribe = function (stream) { exports.unsubscribe_button_click = function (e) {
var stream = $(e.target).parent().prev().find('.subscription_name').text();
$.ajax({ $.ajax({
type: "POST", type: "POST",
url: "/json/subscriptions/remove", url: "/json/subscriptions/remove",