From 7dfa0edfa6ee96e5d20d2911285f9def2f54117e Mon Sep 17 00:00:00 2001 From: Tim Abbott Date: Wed, 18 Apr 2018 11:36:31 -0700 Subject: [PATCH] slack import: Don't try to import pinned/unpinned items. There isn't a corresponding Zulip concept, and they don't have a "text" attribute, so there's no message content to import. --- zerver/lib/slack_data_to_zulip_data.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/zerver/lib/slack_data_to_zulip_data.py b/zerver/lib/slack_data_to_zulip_data.py index fbbb4f4068..9e076756ac 100755 --- a/zerver/lib/slack_data_to_zulip_data.py +++ b/zerver/lib/slack_data_to_zulip_data.py @@ -667,6 +667,10 @@ def channel_message_to_zerver_message(realm_id: int, users: List[ZerverFieldsT], # These are Sometimes produced by slack continue if message.get('subtype') in [ + # Zulip doesn't have a pinned_item concept + "pinned_item", + "unpinned_item", + # Slack's channel join/leave notices are spammy "channel_join", "channel_leave", "channel_name"