paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-11 01:16:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

message: Show error while resolving/unresolving topic.

Browse Source 
We were not showing the error, if any, when resolving and
unresolving the topic using topic popover in left sidebar
or using the banner in compose box. This commit adds code
to show the error in the message feed where we show other
errors like connection error, etc.
This commit is contained in:
Sahil Batra
2023-05-24 17:12:18 +05:30
committed by Tim Abbott
parent 457ff73082
commit 7f4f905ec8
4 changed files with 16 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
web/src/message_edit.js
View File

@@ -697,7 +697,7 @@ function handle_resolve_topic_failure_due_to_time_limit(topic_is_resolved) {
});
}
export function toggle_resolve_topic(message_id, old_topic_name) {
export function toggle_resolve_topic(message_id, old_topic_name, report_errors_in_global_banner) {
let new_topic_name;
const topic_is_resolved = resolved_topic.is_resolved(old_topic_name);
if (topic_is_resolved) {
@@ -719,6 +719,12 @@ export function toggle_resolve_topic(message_id, old_topic_name) {
error(xhr) {
if (xhr.responseJSON.code === "MOVE_MESSAGES_TIME_LIMIT_EXCEEDED") {
handle_resolve_topic_failure_due_to_time_limit(topic_is_resolved);
return;
}
if (report_errors_in_global_banner) {
const error_msg = JSON.parse(xhr.responseText).msg;
ui_report.generic_embed_error(error_msg, 3500);
}
},
});