paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

left sidebar: Avoid unnecessary scrollbar.

Browse Source 
This commit modifies the `#add-stream-link` element to be a `div`
containing the previous `a` element. The margin that was added to
`#stream-filters-container .simplebar-content` is then moved to that new
`div`.

This preserves the intended behaviour of the commit which introduced
the margin, to fix #12519 while removing an unnecessary scrollbar
which could hide the top-most stream in the stream list.

Fixes #13050

Signed-off-by: David Wood <david@davidtw.co>
This commit is contained in:
David Wood
2019-10-15 16:43:33 +01:00
committed by Tim Abbott
parent c10f3f87b7
commit 7fc72dff44
2 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
static/styles/left-sidebar.scss
View File

@@ -125,10 +125,6 @@ li.show-more-topics a {
width: 100%; width: 100%;
} }
#stream-filters-container .simplebar-content {
margin-bottom: 18px;
}
#private-container { #private-container {
max-height: 200px; max-height: 200px;
} }
@@ -147,6 +143,7 @@ li.show-more-topics a {
#add-stream-link { #add-stream-link {
text-decoration: none; text-decoration: none;
margin-left: 10px; margin-left: 10px;
margin-bottom: 18px;
} }
#add-stream-link i { #add-stream-link i {

4
templates/zerver/app/left_sidebar.html
View File

@@ -74,7 +74,9 @@
<div id="stream-filters-container" class="scrolling_list" data-simplebar> <div id="stream-filters-container" class="scrolling_list" data-simplebar>
<ul id="stream_filters" class="filters"></ul> <ul id="stream_filters" class="filters"></ul>
{% if show_add_streams %} {% if show_add_streams %}
<a id="add-stream-link" href="#streams/all"><i class="fa fa-plus-circle" aria-hidden="true"></i>{{ _('Add streams') }}</a> <div id="add-stream-link">
<a href="#streams/all"><i class="fa fa-plus-circle" aria-hidden="true"></i>{{ _('Add streams') }}</a>
</div>
{% endif %} {% endif %}
</div> </div>
</div> </div>