paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 22:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Extract message_scroll.js.

Browse Source 
This mostly moves code from ui.js.

We change the arguments to `message_fetch.load_more_messages()`
to be `opts` with callbacks for `show_loading` and `hide_loading`.

We also defer starting the scroll handler until `message_fetch.js`
has been initialized.
This commit is contained in:
Steve Howell
2018-03-08 14:18:36 -05:00
committed by Tim Abbott
parent 7819319695
commit 8063f73f6d
7 changed files with 84 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
static/js/message_fetch.js
View File

@@ -9,7 +9,7 @@ var load_more_enabled = true;
exports.reset_load_more_status = function reset_load_more_status() {
load_more_enabled = true;
ui.hide_loading_more_messages_indicator();
message_scroll.hide_loading_more_messages_indicator();
};
function process_result(messages, opts) {
@@ -122,13 +122,14 @@ exports.load_old_messages = function load_old_messages(opts) {
};
exports.load_more_messages = function load_more_messages(msg_list) {
exports.load_more_messages = function (opts) {
var msg_list = opts.msg_list;
var batch_size = 100;
var oldest_message_id;
if (!load_more_enabled) {
return;
}
ui.show_loading_more_messages_indicator();
opts.show_loading();
load_more_enabled = false;
if (msg_list.first() === undefined) {
oldest_message_id = page_params.pointer;
@@ -141,7 +142,7 @@ exports.load_more_messages = function load_more_messages(msg_list) {
num_after: 0,
msg_list: msg_list,
cont: function (messages) {
ui.hide_loading_more_messages_indicator();
opts.hide_loading();
if (messages.length >= batch_size) {
load_more_enabled = true;
}