paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

typing: Fix misuse of HttpResponse.

Browse Source 
Amend usage of HttpResponse when appropriate.
This commit is contained in:
PIG208
2021-07-26 22:29:19 +08:00
parent ad8d9f2133
commit 8121d2d58d
7 changed files with 38 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
zerver/views/streams.py
View File

@@ -167,7 +167,7 @@ def create_default_stream_group(
group_name: str = REQ(),
description: str = REQ(),
stream_names: List[str] = REQ(json_validator=check_list(check_string)),
) -> None:
) -> HttpResponse:
streams = []
for stream_name in stream_names:
(stream, sub) = access_stream_by_name(user_profile, stream_name)
@@ -184,7 +184,7 @@ def update_default_stream_group_info(
group_id: int,
new_group_name: Optional[str] = REQ(default=None),
new_description: Optional[str] = REQ(default=None),
) -> None:
) -> HttpResponse:
if not new_group_name and not new_description:
raise JsonableError(_('You must pass "new_description" or "new_group_name".'))
@@ -204,7 +204,7 @@ def update_default_stream_group_streams(
group_id: int,
op: str = REQ(),
stream_names: List[str] = REQ(json_validator=check_list(check_string)),
) -> None:
) -> HttpResponse:
group = access_default_stream_group_by_id(user_profile.realm, group_id)
streams = []
for stream_name in stream_names:
@@ -224,7 +224,7 @@ def update_default_stream_group_streams(
@has_request_variables
def remove_default_stream_group(
request: HttpRequest, user_profile: UserProfile, group_id: int
) -> None:
) -> HttpResponse:
group = access_default_stream_group_by_id(user_profile.realm, group_id)
do_remove_default_stream_group(user_profile.realm, group)
return json_success()