paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-10 00:46:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

stream_data: Refactored function to return sub and can_sub streams.

Browse Source 
This commit refactors the 'get_subscribed_streams_for_user' function
to return an object with two keys: one for the subscribed streams
and another for the streams the user can subscribe to. The node
tests have been updated accordingly.

Renamed 'get_subscribed_streams_for_user' to 'get_streams_for_user'.
This commit is contained in:
palashb01
2023-07-29 04:19:51 +05:30
committed by Tim Abbott
parent 94fe762ea5
commit 8198a04ce8
3 changed files with 30 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
web/src/stream_data.ts
View File

@@ -388,11 +388,15 @@ export function muted_stream_ids(): number[] {
.map((sub) => sub.stream_id);
}
export function get_subscribed_streams_for_user(user_id: number): StreamSubscription[] {
export function get_streams_for_user(user_id: number): {
subscribed: StreamSubscription[];
can_subscribe: StreamSubscription[];
} {
// Note that we only have access to subscribers of some streams
// depending on our role.
const all_subs = get_unsorted_subs();
const subscribed_subs = [];
const can_subscribe_subs = [];
for (const sub of all_subs) {
if (!can_view_subscribers(sub)) {
// Private streams that we have been removed from appear
@@ -402,10 +406,15 @@ export function get_subscribed_streams_for_user(user_id: number): StreamSubscrip
}
if (is_user_subscribed(sub.stream_id, user_id)) {
subscribed_subs.push(sub);
} else if (can_subscribe_others(sub)) {
can_subscribe_subs.push(sub);
}
}
return subscribed_subs;
return {
subscribed: subscribed_subs,
can_subscribe: can_subscribe_subs,
};
}
export function get_invite_stream_data(): InviteStreamData[] {