From 81ab0b36158ebdda17664b11d88951036de67669 Mon Sep 17 00:00:00 2001 From: Zixuan James Li Date: Thu, 23 Jun 2022 14:44:31 -0400 Subject: [PATCH] user_activity: Tighten function signatures with generic QuerySet. Signed-off-by: Zixuan James Li --- analytics/views/user_activity.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/analytics/views/user_activity.py b/analytics/views/user_activity.py index d3fccc8f0a..43d1d5e1d2 100644 --- a/analytics/views/user_activity.py +++ b/analytics/views/user_activity.py @@ -17,7 +17,9 @@ if settings.BILLING_ENABLED: pass -def get_user_activity_records(user_profile: UserProfile) -> List[QuerySet]: +def get_user_activity_records( + user_profile: UserProfile, +) -> QuerySet[UserActivity]: fields = [ "user_profile__full_name", "query", @@ -34,7 +36,7 @@ def get_user_activity_records(user_profile: UserProfile) -> List[QuerySet]: return records -def raw_user_activity_table(records: List[QuerySet]) -> str: +def raw_user_activity_table(records: QuerySet[UserActivity]) -> str: cols = [ "query", "client", @@ -42,7 +44,7 @@ def raw_user_activity_table(records: List[QuerySet]) -> str: "last_visit", ] - def row(record: QuerySet) -> List[Any]: + def row(record: UserActivity) -> List[Any]: return [ record.query, record.client.name,