paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 22:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_edit: Fix 'stream_and_topic_exist_in_edit_history' for topic="".

Browse Source 
This commit fixes the 'stream_and_topic_exist_in_edit_history'
function for empty string topic.

Earlier, `if` statements were not checking toipc===undefined explicitly
resulting in buggy behaviour when topic="".
This commit is contained in:
Prakhar Pratyush
2025-02-18 21:00:40 +05:30
committed by Tim Abbott
parent 08b1ec7b55
commit 82646c4d96
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
web/src/message_edit.ts
View File

@@ -311,7 +311,7 @@ export function stream_and_topic_exist_in_edit_history(
} }
for (const edit_history_event of message.edit_history) { for (const edit_history_event of message.edit_history) {
if (!edit_history_event.prev_stream && !edit_history_event.prev_topic) { if (!edit_history_event.prev_stream && edit_history_event.prev_topic === undefined) {
// Message was not moved in this edit event. // Message was not moved in this edit event.
continue; continue;
} }
@@ -324,7 +324,7 @@ export function stream_and_topic_exist_in_edit_history(
message_dict.stream_id = edit_history_event.prev_stream; message_dict.stream_id = edit_history_event.prev_stream;
} }
if (edit_history_event.prev_topic) { if (edit_history_event.prev_topic !== undefined) {
// This edit event changed the topic. We expect the // This edit event changed the topic. We expect the
// following to be true due to the invariants of the edit // following to be true due to the invariants of the edit
// history data structure: // history data structure: