paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-15 19:31:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

update_stream_backend: Use access_stream_by_id.

Browse Source
This commit is contained in:
Tim Abbott
2017-01-29 16:51:43 -08:00
parent de38f3eb94
commit 826cc80c9e
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
zerver/tests/test_subs.py
View File

@@ -122,7 +122,7 @@ class StreamAdminTest(ZulipTestCase):
} }
stream_id = get_stream('private_stream', user_profile.realm).id stream_id = get_stream('private_stream', user_profile.realm).id
result = self.client_patch("/json/streams/%d" % (stream_id,), params) result = self.client_patch("/json/streams/%d" % (stream_id,), params)
self.assert_json_error(result, 'You are not invited to this stream.') self.assert_json_error(result, 'Invalid stream id')
self.subscribe_to_stream(email, 'private_stream') self.subscribe_to_stream(email, 'private_stream')

2
zerver/views/streams.py
View File

@@ -164,7 +164,7 @@ def update_stream_backend(request, user_profile, stream_id,
is_private=REQ(validator=check_bool, default=None), is_private=REQ(validator=check_bool, default=None),
new_name=REQ(validator=check_string, default=None)): new_name=REQ(validator=check_string, default=None)):
# type: (HttpRequest, UserProfile, int, Optional[Text], Optional[bool], Optional[Text]) -> HttpResponse # type: (HttpRequest, UserProfile, int, Optional[Text], Optional[bool], Optional[Text]) -> HttpResponse
stream = get_and_validate_stream_by_id(stream_id, user_profile.realm) (stream, recipient, sub) = access_stream_by_id(user_profile, stream_id)
if description is not None: if description is not None:
do_change_stream_description(user_profile.realm, stream.name, description) do_change_stream_description(user_profile.realm, stream.name, description)