From 827aaa227e1d79b01accff7681dcca181d88d225 Mon Sep 17 00:00:00 2001 From: Aman Agrawal Date: Sat, 16 Jan 2021 07:42:53 +0000 Subject: [PATCH] stream_edit: Extract generic pill functions to be reused in future. --- static/js/stream_edit.js | 35 ++++++++++++++++++----------------- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/static/js/stream_edit.js b/static/js/stream_edit.js index 71d09ccd27..4cbf1fd898 100644 --- a/static/js/stream_edit.js +++ b/static/js/stream_edit.js @@ -292,6 +292,22 @@ exports.sort_but_pin_current_user_on_top = function (users) { } }; +exports.create_item_from_text = function (text, current_items) { + const item = stream_pill.create_item_from_stream_name(text, current_items); + if (item) { + return item; + } + return user_pill.create_item_from_email(text, current_items); +}; + +exports.get_text_from_item = function (item) { + const text = stream_pill.get_stream_name_from_item(item); + if (text) { + return text; + } + return user_pill.get_email_from_item(item); +}; + function show_subscription_settings(sub) { const stream_id = sub.stream_id; const sub_settings = exports.settings_for_sub(sub); @@ -307,25 +323,10 @@ function show_subscription_settings(sub) { )}'] .pill-container`, ); - function create_item_from_text(text, current_items) { - const item = stream_pill.create_item_from_stream_name(text, current_items); - if (item) { - return item; - } - return user_pill.create_item_from_email(text, current_items); - } - function get_text_from_item(item) { - const text = stream_pill.get_stream_name_from_item(item); - if (text) { - return text; - } - return user_pill.get_email_from_item(item); - } - exports.pill_widget = input_pill.create({ container, - create_item_from_text, - get_text_from_item, + create_item_from_text: exports.create_item_from_text, + get_text_from_item: exports.get_text_from_item, }); if (!sub.render_subscribers) {