paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 14:35:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

copy_message_button: Use div HTML tag instead of button.

Browse Source 
For some reason, browser is treating clicking on the button as
submitting the form, which results in the page getting redirected
to the same page with an additional empty query `?` in the URL.
This commit is contained in:
Aman Agrawal
2023-03-18 10:20:58 +00:00
committed by Tim Abbott
parent e65e78719d
commit 83423bb45b
2 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
web/styles/zulip.css
View File

@@ -597,10 +597,18 @@ li,
}
.copy_message {
float: right;
position: relative;
top: 27px;
left: -10px;
margin-top: -24px;
cursor: pointer;
top: 30px;
/* To make sure the svg doesn't occupy any vertical space. */
margin-top: -30px;
right: 2px;
padding-top: 2px;
#clipboard_image {
margin: 0;
}
}
#copy_generated_invite_link {

4
web/templates/copy_message_button.hbs
View File

@@ -1,3 +1,3 @@
<button class="btn pull-right copy_button_base copy_message tippy-zulip-tooltip" data-tippy-content="{{t 'Copy and close' }}" aria-label="{{t 'Copy and close' }}" >
<div class="copy_button_base copy_message tippy-zulip-tooltip" data-tippy-content="{{t 'Copy and close' }}" aria-label="{{t 'Copy and close' }}" role="button">
{{> copy_to_clipboard_svg }}
</button>
</div>