paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 22:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

compose: Use class to find markdown_preview related elements.

Browse Source 
We convert the following elements to use a class instead of
id for accessing them across the codebase:

* markdown_preview
* undo_markdown_preview
* markdown_preview_spinner
* message_edit_content
* preview_content

Converted them together since changes to one impacted the other in
some modules like click_handlers.

Also, added a function in rows to get `message_row`.
This commit is contained in:
Aman Agrawal
2021-04-20 17:50:01 +00:00
committed by Tim Abbott
parent 8ebced2791
commit 84a7f08acc
17 changed files with 120 additions and 114 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
static/js/upload.js
View File

@@ -56,7 +56,7 @@ export function get_item(key, config) {
case "drag_drop_container":
return $("#compose");
case "markdown_preview_hide_button":
return $("#undo_markdown_preview");
return $("#compose .undo_markdown_preview");
default:
throw new Error(`Invalid key name for mode "${config.mode}"`);
}
@@ -66,9 +66,9 @@ export function get_item(key, config) {
}
switch (key) {
case "textarea":
return $(`#message_edit_content_${CSS.escape(config.row)}`);
return $(`#edit_form_${CSS.escape(config.row)} .message_edit_content`);
case "send_button":
return $(`#message_edit_content_${CSS.escape(config.row)}`)
return $(`#edit_form_${CSS.escape(config.row)} .message_edit_content`)
.closest(".message_edit_form")
.find(".message_edit_save");
case "send_status_identifier":
@@ -88,7 +88,7 @@ export function get_item(key, config) {
case "drag_drop_container":
return $(".message_edit_form");
case "markdown_preview_hide_button":
return $(`#undo_markdown_preview_${CSS.escape(config.row)}`);
return $(`#edit_form_${CSS.escape(config.row)} .undo_markdown_preview`);
default:
throw new Error(`Invalid key name for mode "${config.mode}"`);
}