paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs: Add documentation on using icons.

Browse Source
This commit is contained in:
Tim Abbott
2025-01-21 16:16:52 -08:00
parent d4426f3bab
commit 84be984619
2 changed files with 32 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
docs/subsystems/html-css.md
View File

@@ -214,7 +214,8 @@ first add it to the appropriate place under `static/`.
`web/src/portico`. `web/src/portico`.
- Custom SVG graphics living under `web/images/icons` are compiled into - Custom SVG graphics living under `web/images/icons` are compiled into
custom icon webfonts by webfont-loader according to the custom icon webfonts by webfont-loader according to the
`web/images/icons/template.hbs` template. `web/images/icons/template.hbs` template. See
[icons](../subsystems/icons.md) for more details on adding icons.
For your asset to be included in a development/production bundle, it For your asset to be included in a development/production bundle, it
needs to be accessible from one of the entry points defined either in needs to be accessible from one of the entry points defined either in

31
docs/subsystems/icons.md
View File

@@ -1,5 +1,33 @@
# Icons # Icons
Zulip makes extensive use of icons to decorate elements in the UI as
well as for compact buttons.
## Using icons
- Modern Zulip icons are implemented using `<i class="zulip-icon
zulip-icon-smile"></i>`, which is rendered using generated CSS that
maps that class name combination to displaying the SVG file located
at `web/shared/icons/smile.svg`.
- Older icons use [Font Awesome 4.7](https://fontawesome.com/),
declared in our HTML via `<i class="fa fa-paperclip"></i>`. We are
migrating away from Font Awesome both for design and licensing
reasons (Font Awesome 5.0+ is no longer fully open source).
Always consider [accessibility](../subsystems/accessibility.md) when
using icons. Typically, this means:
- Icons that are used **purely as a decoration** to a textual label (for
example, in our popover menus) should use `aria-hidden`, so that
screenreaders ignore them in favor of reading the label.
- Buttons whose **entire label** is an icon should have a
[tooltip](../subsystems/html-css.md#tooltips) as well as an
`aria-label` declaration, so that screenreaders will explain the
button. Generally, the tooltip text should be identical to the
`aria-label` text.
## Adding a new icon ## Adding a new icon
A new feature may require a new icon to represent it, for example to be used A new feature may require a new icon to represent it, for example to be used
@@ -7,7 +35,8 @@ next to a menu option. The issue you're working on may not have an icon
specified upfront. In this case, you should: specified upfront. In this case, you should:
1. Prototype using a [Lucide icon](https://lucide.dev/icons/), which is the 1. Prototype using a [Lucide icon](https://lucide.dev/icons/), which is the
default source for icons in Zulip. default source for icons in Zulip. SVG files must be added under
`web/shared/icons/` (don't forget to `git add`) to be used.
1. **When your feature is nearing completion**, post in the [appropriate 1. **When your feature is nearing completion**, post in the [appropriate
channel](https://zulip.com/development-community/#where-do-i-send-my-message) channel](https://zulip.com/development-community/#where-do-i-send-my-message)