From 84fc8f16dd5333ebd5e20143f07703a76f2bcb95 Mon Sep 17 00:00:00 2001 From: Steve Howell Date: Thu, 13 Mar 2014 11:39:29 -0400 Subject: [PATCH] Add test coverage for util.same_major_recipient. (imported from commit 0b345679d2bf40c82167ded9968dd653823011bf) --- zerver/tests/frontend/node/util.js | 47 +++++++++++++++++++++--------- 1 file changed, 33 insertions(+), 14 deletions(-) diff --git a/zerver/tests/frontend/node/util.js b/zerver/tests/frontend/node/util.js index 1d23e6320c..2af6c209b6 100644 --- a/zerver/tests/frontend/node/util.js +++ b/zerver/tests/frontend/node/util.js @@ -3,6 +3,7 @@ add_dependencies({ }); var util = global.util; +var _ = global._; (function test_CachedValue() { var x = 5; @@ -44,25 +45,43 @@ var util = global.util; }()); (function test_same_recipient() { - assert(util.same_recipient( - {type: 'stream', stream: 'Foo', subject: 'Bar'}, - {type: 'stream', stream: 'fOO', subject: 'bar'} + _.each([util.same_recipient, util.same_major_recipient], function (same) { + assert(same( + {type: 'stream', stream: 'Foo', subject: 'Bar'}, + {type: 'stream', stream: 'fOO', subject: 'bar'} + )); + + assert(!same( + {type: 'stream', stream: 'Foo', subject: 'Bar'}, + {type: 'stream', stream: 'yo', subject: 'whatever'} + )); + + assert(same( + {type: 'private', reply_to: 'fred@zulip.com,melissa@zulip.com'}, + {type: 'private', reply_to: 'fred@zulip.com,melissa@zulip.com'} + )); + + assert(!same( + {type: 'private', reply_to: 'fred@zulip.com'}, + {type: 'private', reply_to: 'Fred@zulip.com'} + )); + + assert(!same( + {type: 'stream', stream: 'Foo', subject: 'Bar'}, + {type: 'private', reply_to: 'Fred@zulip.com'} + )); + }); + + assert(util.same_major_recipient( + {type: 'stream', stream: 'Foo', subject: 'sub1'}, + {type: 'stream', stream: 'fOO', subject: 'sub2'} )); assert(!util.same_recipient( - {type: 'stream', stream: 'Foo', subject: 'Bar'}, - {type: 'stream', stream: 'yo', subject: 'whatever'} + {type: 'stream', stream: 'Foo', subject: 'sub1'}, + {type: 'stream', stream: 'fOO', subject: 'sub2'} )); - assert(util.same_recipient( - {type: 'private', reply_to: 'fred@zulip.com,melissa@zulip.com'}, - {type: 'private', reply_to: 'fred@zulip.com,melissa@zulip.com'} - )); - - assert(!util.same_recipient( - {type: 'private', reply_to: 'fred@zulip.com'}, - {type: 'private', reply_to: 'Fred@zulip.com'} - )); }()); (function test_robust_uri_decode() {