paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

stream_edit: Remove separate click handlers from notifications checkboxes.

Browse Source 
Rather than looping on each setting checkbox (except "Mute stream"), we can
attach single click handler to `.sub_setting_checkbox` class.
This commit is contained in:
Pragati Agrawal
2020-02-04 16:16:36 +05:30
committed by Tim Abbott
parent 30d02c2e2c
commit 84fd0b0974
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
static/js/stream_edit.js
View File

@@ -308,6 +308,9 @@ function stream_is_muted_clicked(e) {
}
function stream_setting_clicked(e) {
if (e.currentTarget.id === 'sub_is_muted_setting') {
return;
}
const checkbox_div = $(e.target).closest(".sub_setting_checkbox");
const sub = get_sub_for_target(e.target);
const checkbox = checkbox_div.find('.sub_setting_control');
@@ -517,13 +520,8 @@ exports.initialize = function () {
$("#subscriptions_table").on("click", "#sub_is_muted_setting",
stream_is_muted_clicked);
_.each(Object.keys(settings_labels), function (setting) {
if (setting === "is_muted") {
return;
}
$("#subscriptions_table").on("click", "#sub_" + setting + "_setting",
stream_setting_clicked);
});
$("#subscriptions_table").on("click", ".sub_setting_checkbox",
stream_setting_clicked);
$("#subscriptions_table").on("submit", ".subscriber_list_add form", function (e) {
e.preventDefault();