paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 13:03:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

parse_user_agent: Assert user agent is not None.

Browse Source 
This commit asserts that parse_user_agent never returns None. The
RegEx will match any string, so that `match` is never None. This
brings test coverage of lib/user_agent.py to 100%. Changes were also
made in test/test_decorators.py and views/compatibility.py to reflect
that parse_user_agent cannot return None.

Improves: #7089.
Fixes: #8779.
This commit is contained in:
Jack Weatherilt
2018-03-22 19:02:15 +00:00
committed by Tim Abbott
parent 66b007acf0
commit 8535625341
3 changed files with 4 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
zerver/views/compatibility.py
View File

@@ -7,6 +7,6 @@ from zerver.lib.user_agent import parse_user_agent
def check_compatibility(request: HttpRequest) -> HttpResponse:
user_agent = parse_user_agent(request.META["HTTP_USER_AGENT"])
if user_agent is None or user_agent['name'] == "ZulipInvalid":
if user_agent['name'] == "ZulipInvalid":
return json_error("Client is too old")
return json_success()